ammar/backend
1
0
Fork 0
mirror of https://github.com/SyncrowIOT/backend.git synced 2025-07-17 03:05:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #333 from SyncrowIOT/SP-1430-be-api-request-returns-400-bad-request-instead-of-empty-array-when-community-has-no-devices-or-spaces

Browse Source 
refactor: improve error handling for missing space in device listing
This commit is contained in:
faljawhary
2025-04-14 14:26:37 +03:00
committed by GitHub
parent 846b7e6463 777105fc28
commit 9f3dce535d
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/space/services/space-device.service.ts
View File

@ -25,11 +25,8 @@ export class SpaceDeviceService {
// Validate community, project, and fetch space including devices in a single query
const space = await this.validationService.fetchSpaceDevices(spaceUuid);
if (!space || !space.devices?.length) {
throw new HttpException(
'The space does not contain any devices.',
HttpStatus.BAD_REQUEST,
);
if (!space) {
throw new HttpException('Space not found', HttpStatus.NOT_FOUND);
}
const spaceHierarchy =