fix: fix null assertion in creating junior

src/auth/controllers/auth.controller.ts

@@ -9,9 +9,11 @@ import {
   ChangePasswordRequestDto,
   CreateUnverifiedUserRequestDto,
   ForgetPasswordRequestDto,
+  JuniorLoginRequestDto,
   LoginRequestDto,
   RefreshTokenRequestDto,
   SendForgetPasswordOtpRequestDto,
+  setJuniorPasswordRequestDto,
   VerifyForgetPasswordOtpRequestDto,
   VerifyUserRequestDto,
 } from '../dtos/request';
@@ -69,10 +71,26 @@ export class AuthController {
   @Post('change-password')
   @HttpCode(HttpStatus.NO_CONTENT)
   @UseGuards(AccessTokenGuard)
-  async changePassword(@AuthenticatedUser() { sub }: IJwtPayload, @Body() forgetPasswordDto: ChangePasswordRequestDto) {
+  changePassword(@AuthenticatedUser() { sub }: IJwtPayload, @Body() forgetPasswordDto: ChangePasswordRequestDto) {
     return this.authService.changePassword(sub, forgetPasswordDto);
   }
 
+  @Post('junior/set-password')
+  @HttpCode(HttpStatus.NO_CONTENT)
+  @Public()
+  setJuniorPasscode(@Body() setPassworddto: setJuniorPasswordRequestDto) {
+    return this.authService.setJuniorPassword(setPassworddto);
+  }
+
+  @Post('junior/login')
+  @HttpCode(HttpStatus.OK)
+  @ApiDataResponse(LoginResponseDto)
+  async juniorLogin(@Body() juniorLoginDto: JuniorLoginRequestDto) {
+    const [res, user] = await this.authService.juniorLogin(juniorLoginDto);
+
+    return ResponseFactory.data(new LoginResponseDto(res, user));
+  }
+
   @Post('refresh-token')
   @Public()
   async refreshToken(@Body() { refreshToken }: RefreshTokenRequestDto) {

src/auth/dtos/request/index.ts

@@ -1,11 +1,11 @@
 export * from './change-password.request.dto';
 export * from './create-unverified-user.request.dto';
 export * from './forget-password.request.dto';
+export * from './junior-login.request.dto';
 export * from './login.request.dto';
 export * from './refresh-token.request.dto';
 export * from './send-forget-password-otp.request.dto';
 export * from './set-junior-password.request.dto';
-export * from './set-passcode.request.dto';
 export * from './verify-forget-password-otp.request.dto';
 export * from './verify-otp.request.dto';
 export * from './verify-user.request.dto';

src/auth/dtos/request/junior-login.request.dto.ts

@@ -0,0 +1,12 @@
+import { ApiProperty } from '@nestjs/swagger';
+import { IsEmail, IsString } from 'class-validator';
+import { i18nValidationMessage as i18n } from 'nestjs-i18n';
+export class JuniorLoginRequestDto {
+  @ApiProperty({ example: 'test@junior.com' })
+  @IsEmail({}, { message: i18n('validation.IsEmail', { path: 'general', property: 'auth.email' }) })
+  email!: string;
+
+  @ApiProperty({ example: 'Abcd1234@' })
+  @IsString({ message: i18n('validation.IsString', { path: 'general', property: 'auth.password' }) })
+  password!: string;
+}

src/auth/dtos/request/set-junior-password.request.dto.ts

@@ -1,8 +1,11 @@
-import { ApiProperty } from '@nestjs/swagger';
+import { ApiProperty, PickType } from '@nestjs/swagger';
 import { IsNotEmpty, IsString } from 'class-validator';
 import { i18nValidationMessage as i18n } from 'nestjs-i18n';
-import { SetPasscodeRequestDto } from './set-passcode.request.dto';
+import { ChangePasswordRequestDto } from './change-password.request.dto';
-export class setJuniorPasswordRequestDto extends SetPasscodeRequestDto {
+export class setJuniorPasswordRequestDto extends PickType(ChangePasswordRequestDto, [
+  'newPassword',
+  'confirmNewPassword',
+]) {
   @ApiProperty()
   @IsString({ message: i18n('validation.IsNumberString', { path: 'general', property: 'auth.qrToken' }) })
   @IsNotEmpty({ message: i18n('validation.IsNotEmpty', { path: 'general', property: 'auth.qrToken' }) })

src/auth/dtos/request/set-passcode.request.dto.ts

@@ -1,15 +0,0 @@
-import { ApiProperty } from '@nestjs/swagger';
-import { IsNumberString, MaxLength, MinLength } from 'class-validator';
-import { i18nValidationMessage as i18n } from 'nestjs-i18n';
-const PASSCODE_LENGTH = 6;
-
-export class SetPasscodeRequestDto {
-  @ApiProperty({ example: '123456' })
-  @IsNumberString(
-    { no_symbols: true },
-    { message: i18n('validation.IsNumberString', { path: 'general', property: 'auth.passcode' }) },
-  )
-  @MinLength(PASSCODE_LENGTH, { message: i18n('validation.MinLength', { path: 'general', property: 'auth.passcode' }) })
-  @MaxLength(PASSCODE_LENGTH, { message: i18n('validation.MaxLength', { path: 'general', property: 'auth.passcode' }) })
-  passcode!: string;
-}

src/auth/services/auth.service.ts

@@ -14,6 +14,7 @@ import {
   ChangePasswordRequestDto,
   CreateUnverifiedUserRequestDto,
   ForgetPasswordRequestDto,
+  JuniorLoginRequestDto,
   LoginRequestDto,
   SendForgetPasswordOtpRequestDto,
   setJuniorPasswordRequestDto,
@@ -196,11 +197,14 @@ export class AuthService {
     this.logger.log(`Password changed successfully for user with id ${userId}`);
   }
 
-  async setJuniorPasscode(body: setJuniorPasswordRequestDto) {
+  async setJuniorPassword(body: setJuniorPasswordRequestDto) {
     this.logger.log(`Setting passcode for junior with qrToken ${body.qrToken}`);
+    if (body.newPassword != body.confirmNewPassword) {
+      throw new BadRequestException('AUTH.PASSWORD_MISMATCH');
+    }
     const juniorId = await this.userTokenService.validateToken(body.qrToken, UserType.JUNIOR);
     const salt = bcrypt.genSaltSync(SALT_ROUNDS);
-    const hashedPasscode = bcrypt.hashSync(body.passcode, salt);
+    const hashedPasscode = bcrypt.hashSync(body.newPassword, salt);
     await this.userService.setPassword(juniorId!, hashedPasscode, salt);
     await this.userTokenService.invalidateToken(body.qrToken);
     this.logger.log(`Passcode set successfully for junior with id ${juniorId}`);
@@ -278,6 +282,26 @@ export class AuthService {
     return [tokens, user];
   }
 
+  async juniorLogin(juniorLoginDto: JuniorLoginRequestDto): Promise<[ILoginResponse, User]> {
+    const user = await this.userService.findUser({ email: juniorLoginDto.email });
+
+    if (!user || !user.roles.includes(Roles.JUNIOR)) {
+      throw new UnauthorizedException('AUTH.INVALID_CREDENTIALS');
+    }
+
+    this.logger.log(`validating password for user with email ${juniorLoginDto.email}`);
+    const isPasswordValid = bcrypt.compareSync(juniorLoginDto.password, user.password);
+
+    if (!isPasswordValid) {
+      this.logger.error(`Invalid password for user with email ${juniorLoginDto.email}`);
+      throw new UnauthorizedException('AUTH.INVALID_CREDENTIALS');
+    }
+
+    const tokens = await this.generateAuthToken(user);
+    this.logger.log(`Password validated successfully for user`);
+    return [tokens, user];
+  }
+
   private async generateAuthToken(user: User) {
     this.logger.log(`Generating auth token for user with id ${user.id}`);
     const [accessToken, refreshToken] = await Promise.all([

src/card/entities/card.entity.ts

@@ -39,7 +39,7 @@ export class Card {
   @Column({ type: 'varchar', nullable: false, name: 'customer_type' })
   customerType!: CustomerType;
 
-  @Column({ type: 'varchar', nullable: false, default: CardColors.BLUE })
+  @Column({ type: 'varchar', nullable: false, default: CardColors.DEEP_MAGENTA })
   color!: CardColors;
 
   @Column({ type: 'varchar', nullable: false, default: CardStatus.PENDING })

src/card/enums/card-colors.enum.ts

@@ -1,4 +1,13 @@
 export enum CardColors {
-  RED = 'RED',
+  RAINBOW_PASTEL = 'RAINBOW_PASTEL',
-  BLUE = 'BLUE',
+  DEEP_MAGENTA = 'DEEP_MAGENTA',
+  GREEN_TEAL = 'GREEN_TEAL',
+
+  BLUE_GREEN = 'BLUE_GREEN',
+  TEAL_NAVY = 'TEAL_NAVY',
+  PURPLE_PINK = 'PURPLE_PINK',
+
+  GOLD_BLUE = 'GOLD_BLUE',
+  OCEAN_BLUE = 'OCEAN_BLUE',
+  BROWN_RUST = 'BROWN_RUST',
 }

src/card/repositories/card.repository.ts

@@ -9,7 +9,12 @@ import { CardColors, CardIssuers, CardScheme, CardStatus, CardStatusDescription,
 export class CardRepository {
   constructor(@InjectRepository(Card) private readonly cardRepository: Repository<Card>) {}
 
-  createCard(customerId: string, accountId: string, card: CreateApplicationResponse): Promise<Card> {
+  createCard(
+    customerId: string,
+    accountId: string,
+    card: CreateApplicationResponse,
+    cardColor?: CardColors,
+  ): Promise<Card> {
     return this.cardRepository.save(
       this.cardRepository.create({
         customerId: customerId,
@@ -18,7 +23,7 @@ export class CardRepository {
         customerType: CustomerType.PARENT,
         firstSixDigits: card.firstSixDigits,
         lastFourDigits: card.lastFourDigits,
-        color: CardColors.BLUE,
+        color: cardColor ? cardColor : CardColors.DEEP_MAGENTA,
         scheme: CardScheme.VISA,
         issuer: CardIssuers.NEOLEAP,
         accountId: accountId,

src/card/services/card.service.ts

@@ -2,9 +2,11 @@ import { BadRequestException, forwardRef, Inject, Injectable } from '@nestjs/com
 import { Transactional } from 'typeorm-transactional';
 import { AccountCardStatusChangedWebhookRequest } from '~/common/modules/neoleap/dtos/requests';
 import { NeoLeapService } from '~/common/modules/neoleap/services';
+import { Customer } from '~/customer/entities';
 import { KycStatus } from '~/customer/enums';
 import { CustomerService } from '~/customer/services';
 import { Card } from '../entities';
+import { CardColors } from '../enums';
 import { CardStatusMapper } from '../mappers/card-status.mapper';
 import { CardRepository } from '../repositories';
 import { AccountService } from './account.service';
@@ -37,6 +39,17 @@ export class CardService {
     return this.getCardById(createdCard.id);
   }
 
+  async createCardForChild(parentCustomer: Customer, childCustomer: Customer, cardColor: CardColors, cardPin: string) {
+    const data = await this.neoleapService.createChildCard(parentCustomer, childCustomer, cardPin);
+    const createdCard = await this.cardRepository.createCard(
+      childCustomer.id,
+      parentCustomer.cards[0].account.id,
+      data,
+      cardColor,
+    );
+
+    return this.getCardById(createdCard.id);
+  }
   async getCardById(id: string): Promise<Card> {
     const card = await this.cardRepository.getCardById(id);
 

src/common/modules/neoleap/__mocks__/create-application.mock.ts

@@ -1,3 +1,11 @@
+function getRandomWithDigits(digits: number): string {
+  const min = Math.pow(10, digits - 1); // e.g. 1000 for 4 digits
+  const max = Math.pow(10, digits) - 1; // e.g. 9999 for 4 digits
+
+  const result = Math.floor(Math.random() * (max - min + 1)) + min;
+  return result.toString();
+}
+
 export const CREATE_APPLICATION_MOCK = {
   ResponseHeader: {
     Version: '1.0.0',
@@ -673,9 +681,9 @@ export const CREATE_APPLICATION_MOCK = {
     },
     AccountDetailsList: [
       {
-        Id: 21017,
+        Id: getRandomWithDigits(5),
         InstitutionCode: '1100',
-        AccountNumber: '6899999999999999',
+        AccountNumber: getRandomWithDigits(16),
         Currency: {
           CurrCode: '682',
           AlphaCode: 'SAR',
@@ -704,10 +712,10 @@ export const CREATE_APPLICATION_MOCK = {
       {
         pvv: null,
         ResponseCardIdentifier: {
-          Id: 28595,
+          Id: getRandomWithDigits(5),
           Pan: 'DDDDDDDDDDDDDDDDDDD',
           MaskedPan: '999999_9999',
-          VPan: '1100000000000000',
+          VPan: getRandomWithDigits(16),
           Seqno: 0,
         },
         ExpiryDate: '2031-09-30',

src/common/modules/neoleap/services/neoleap.service.ts

@@ -36,6 +36,7 @@ export class NeoLeapService {
   private readonly zodApiUrl: string;
   private readonly apiKey: string;
   private readonly useGateway: boolean;
+  private readonly useKycMock: boolean;
   private readonly institutionCode = '1100';
   useLocalCert: boolean;
   constructor(private readonly httpService: HttpService, private readonly configService: ConfigService) {
@@ -44,12 +45,13 @@ export class NeoLeapService {
     this.useGateway = [true, 'true'].includes(this.configService.get<boolean>('USE_GATEWAY', false));
     this.useLocalCert = this.configService.get<boolean>('USE_LOCAL_CERT', false);
     this.zodApiUrl = this.configService.getOrThrow<string>('ZOD_API_URL');
+    this.useKycMock = [true, 'true'].includes(this.configService.get<boolean>('USE_KYC_MOCK', true));
   }
 
-  async initiateKyc(customerId: string, body: InitiateKycRequestDto) {
+  initiateKyc(customerId: string, body: InitiateKycRequestDto) {
     const responseKey = 'InitiateKycResponseDetails';
 
-    if (!this.useGateway) {
+    if (this.useKycMock) {
       const responseDto = plainToInstance(InitiateKycResponseDto, INITIATE_KYC_MOCK[responseKey], {
         excludeExtraneousValues: true,
       });
@@ -89,7 +91,7 @@ export class NeoLeapService {
     );
   }
 
-  async createApplication(customer: Customer) {
+  createApplication(customer: Customer) {
     const responseKey = 'CreateNewApplicationResponseDetails';
 
     if (!this.useGateway) {
@@ -163,7 +165,82 @@ export class NeoLeapService {
     );
   }
 
-  async inquireApplication(externalApplicationNumber: string) {
+  createChildCard(parent: Customer, child: Customer, cardPin: string) {
+    const responseKey = 'CreateNewApplicationResponseDetails';
+
+    if (!this.useGateway) {
+      return plainToInstance(CreateApplicationResponse, CREATE_APPLICATION_MOCK[responseKey], {
+        excludeExtraneousValues: true,
+      });
+    }
+
+    const payload: ICreateApplicationRequest = {
+      CreateNewApplicationRequestDetails: {
+        ApplicationRequestDetails: {
+          InstitutionCode: this.institutionCode,
+          ExternalApplicationNumber: child.applicationNumber.toString(),
+          ApplicationType: '01',
+          Product: '1101',
+          ApplicationDate: moment().format('YYYY-MM-DD'),
+          BranchCode: '000',
+          ApplicationSource: 'O',
+          DeliveryMethod: 'V',
+        },
+        ApplicationProcessingDetails: {
+          SuggestedLimit: 0,
+          RequestedLimit: 0,
+          AssignedLimit: 0,
+          ProcessControl: 'STND',
+        },
+        ApplicationFinancialInformation: {
+          Currency: {
+            AlphaCode: 'SAR',
+          },
+          BillingCycle: 'C1',
+        },
+        ApplicationOtherInfo: {
+          ParentAccountNumber: parent.cards[0].account.accountNumber,
+        },
+        ApplicationCustomerDetails: {
+          FirstName: parent.firstName,
+          LastName: parent.lastName,
+          FullName: parent.fullName,
+          DateOfBirth: moment(parent.dateOfBirth).format('YYYY-MM-DD'),
+          EmbossName: child.fullName.toUpperCase(), // TODO Enter Emboss Name
+          IdType: '01',
+          IdNumber: parent.nationalId,
+          IdExpiryDate: moment(parent.nationalIdExpiry).format('YYYY-MM-DD'),
+          Title: parent.gender === Gender.MALE ? 'Mr' : 'Ms',
+          Gender: parent.gender === Gender.MALE ? 'M' : 'F',
+          LocalizedDateOfBirth: moment(parent.dateOfBirth).format('YYYY-MM-DD'),
+          Nationality: CountriesNumericISO[parent.countryOfResidence],
+        },
+        ApplicationAddress: {
+          City: parent.city,
+          Country: CountriesNumericISO[parent.country],
+          Region: parent.region,
+          AddressLine1: `${parent.street} ${parent.building}`,
+          AddressLine2: parent.neighborhood,
+          AddressRole: 0,
+          Email: child.user.email,
+          Phone1: child.user.phoneNumber,
+          CountryDetails: {
+            DefaultCurrency: {},
+            Description: [],
+          },
+        },
+      },
+      RequestHeader: this.prepareHeaders('CreateNewApplication'),
+    };
+    return this.sendRequestToNeoLeap<ICreateApplicationRequest, CreateApplicationResponse>(
+      'application/CreateNewApplication',
+      payload,
+      responseKey,
+      CreateApplicationResponse,
+    );
+  }
+
+  inquireApplication(externalApplicationNumber: string) {
     const responseKey = 'InquireApplicationResponseDetails';
     if (!this.useGateway) {
       return plainToInstance(InquireApplicationResponse, INQUIRE_APPLICATION_MOCK[responseKey], {
@@ -195,7 +272,7 @@ export class NeoLeapService {
     );
   }
 
-  async updateCardControl(cardId: string, amount: number, count?: number) {
+  updateCardControl(cardId: string, amount: number, count?: number) {
     const responseKey = 'UpdateCardControlResponseDetails';
     if (!this.useGateway) {
       return;
@@ -224,7 +301,7 @@ export class NeoLeapService {
     );
   }
 
-  async getEmbossingInformation(card: Card) {
+  getEmbossingInformation(card: Card) {
     const responseKey = 'GetEmbossingInformationResponseDetails';
     if (!this.useGateway) {
       return plainToInstance(CardEmbossingDetailsResponseDto, CARD_EMBOSSING_DETAILS_MOCK[responseKey], {
@@ -244,7 +321,7 @@ export class NeoLeapService {
     };
 
     return this.sendRequestToNeoLeap<typeof payload, CardEmbossingDetailsResponseDto>(
-      'cardembossing/CardEmbossingDetails',
+      'issuance/GetEmbossingInformation',
       payload,
       responseKey,
       CardEmbossingDetailsResponseDto,

src/common/modules/notification/listeners/notification-created.listener.ts

@@ -21,7 +21,7 @@ export class NotificationCreatedListener {
   /**
    * Handles the NOTIFICATION_CREATED event by calling the appropriate channel logic.
    */
-  async handle(event: IEventInterface) {
+  handle(event: IEventInterface) {
     this.logger.log(
       `Handling ${EventType.NOTIFICATION_CREATED} event for notification ${event.id} (channel: ${event.channel})`,
     );

src/common/modules/notification/services/notifications.service.ts

@@ -68,7 +68,6 @@ export class NotificationsService {
     });
 
     this.logger.log(`emitting ${EventType.NOTIFICATION_CREATED} event`);
-
     return this.redisPubSubService.publishEvent(EventType.NOTIFICATION_CREATED, {
       ...notification,
       data: { otp },

src/common/modules/otp/services/otp.service.ts

@@ -19,7 +19,6 @@ export class OtpService {
   async generateAndSendOtp(sendOtpRequest: ISendOtp): Promise<string> {
     this.logger.log(`invalidate OTP for ${sendOtpRequest.recipient} and ${sendOtpRequest.otpType}`);
     await this.otpRepository.invalidateOtp(sendOtpRequest);
-
     this.logger.log(`Generating OTP for ${sendOtpRequest.recipient}`);
     const otp = this.useMock ? DEFAULT_OTP_DIGIT.repeat(DEFAULT_OTP_LENGTH) : generateRandomOtp(DEFAULT_OTP_LENGTH);
 

src/customer/repositories/customer.repository.ts

@@ -14,8 +14,7 @@ export class CustomerRepository {
   findOne(where: FindOptionsWhere<Customer>) {
     return this.customerRepository.findOne({
       where,
-      relations: ['user',  'cards'],
+      relations: ['user', 'cards', 'cards.account'],
-
     });
   }
 
@@ -30,6 +29,7 @@ export class CustomerRepository {
         lastName: body.lastName,
         dateOfBirth: body.dateOfBirth,
         countryOfResidence: body.countryOfResidence,
+        gender: body.gender,
       }),
     );
   }

src/customer/services/customer.service.ts

@@ -33,7 +33,10 @@ export class CustomerService {
   async createJuniorCustomer(guardianId: string, juniorId: string, body: CreateJuniorRequestDto) {
     this.logger.log(`Creating junior customer for user ${juniorId}`);
 
-    return this.customerRepository.createCustomer(juniorId, body, false);
+    await this.customerRepository.createCustomer(juniorId, body, false);
+
+    this.logger.log(`Junior customer created for user ${juniorId} successfully`);
+    return this.customerRepository.findOne({ id: juniorId });
   }
 
   async findCustomerById(id: string) {

src/i18n/ar/app.json

@@ -51,7 +51,8 @@
     "NOT_FOUND": "لم يتم العثور على العميل.",
     "ALREADY_EXISTS": "العميل موجود بالفعل.",
     "KYC_NOT_APPROVED": "لم يتم الموافقة على هوية العميل بعد.",
-    "ALREADY_HAS_CARD": "العميل لديه بطاقة بالفعل."
+    "ALREADY_HAS_CARD": "العميل لديه بطاقة بالفعل.",
+    "DOES_NOT_HAVE_CARD": "العميل لا يملك بطاقة."
   },
 
   "GIFT": {

src/i18n/en/app.json

@@ -50,7 +50,8 @@
     "NOT_FOUND": "The customer was not found.",
     "ALREADY_EXISTS": "The customer already exists.",
     "KYC_NOT_APPROVED": "The customer's KYC has not been approved yet.",
-    "ALREADY_HAS_CARD": "The customer already has a card."
+    "ALREADY_HAS_CARD": "The customer already has a card.",
+    "DOES_NOT_HAVE_CARD": "The customer does not have a card."
   },
 
   "GIFT": {

src/junior/dtos/request/create-junior.request.dto.ts

@@ -1,25 +1,19 @@
 import { ApiProperty } from '@nestjs/swagger';
-import { IsDateString, IsEmail, IsEnum, IsNotEmpty, IsOptional, IsString, IsUUID, Matches } from 'class-validator';
+import {
+  IsDateString,
+  IsEmail,
+  IsEnum,
+  IsNotEmpty,
+  IsNumberString,
+  IsOptional,
+  IsString,
+  IsUUID,
+} from 'class-validator';
 import { i18nValidationMessage as i18n } from 'nestjs-i18n';
-import { COUNTRY_CODE_REGEX } from '~/auth/constants';
+import { CardColors } from '~/card/enums';
-import { IsValidPhoneNumber } from '~/core/decorators/validations';
 import { Gender } from '~/customer/enums';
 import { Relationship } from '~/junior/enums';
 export class CreateJuniorRequestDto {
-  @ApiProperty({ example: '+962' })
-  @Matches(COUNTRY_CODE_REGEX, {
-    message: i18n('validation.Matches', { path: 'general', property: 'auth.countryCode' }),
-  })
-  @IsOptional()
-  countryCode: string = '+966';
-
-  @ApiProperty({ example: '787259134' })
-  @IsValidPhoneNumber({
-    message: i18n('validation.IsValidPhoneNumber', { path: 'general', property: 'auth.phoneNumber' }),
-  })
-  @IsOptional()
-  phoneNumber!: string;
-
   @ApiProperty({ example: 'John' })
   @IsString({ message: i18n('validation.IsString', { path: 'general', property: 'customer.firstName' }) })
   @IsNotEmpty({ message: i18n('validation.IsNotEmpty', { path: 'general', property: 'customer.firstName' }) })
@@ -30,9 +24,9 @@ export class CreateJuniorRequestDto {
   @IsNotEmpty({ message: i18n('validation.IsNotEmpty', { path: 'general', property: 'customer.lastName' }) })
   lastName!: string;
 
-  @ApiProperty({ example: 'MALE' })
+  @ApiProperty({ enum: Gender })
   @IsEnum(Gender, { message: i18n('validation.IsEnum', { path: 'general', property: 'customer.gender' }) })
-  gender!: string;
+  gender!: Gender;
 
   @ApiProperty({ example: '2020-01-01' })
   @IsDateString({}, { message: i18n('validation.IsDateString', { path: 'general', property: 'customer.dateOfBirth' }) })
@@ -46,13 +40,13 @@ export class CreateJuniorRequestDto {
   @IsEnum(Relationship, { message: i18n('validation.IsEnum', { path: 'general', property: 'junior.relationship' }) })
   relationship!: Relationship;
 
-  @ApiProperty({ example: 'bf342-3f3f-3f3f-3f3f' })
+  @ApiProperty({ enum: CardColors })
-  @IsUUID('4', { message: i18n('validation.IsUUID', { path: 'general', property: 'junior.civilIdFrontId' }) })
+  @IsEnum(CardColors, { message: i18n('validation.IsEnum', { path: 'general', property: 'junior.cardColor' }) })
-  civilIdFrontId!: string;
+  cardColor!: CardColors;
 
-  @ApiProperty({ example: 'bf342-3f3f-3f3f-3f3f' })
+  @ApiProperty({ example: '1234' })
-  @IsUUID('4', { message: i18n('validation.IsUUID', { path: 'general', property: 'junior.civilIdBackId' }) })
+  @IsNumberString({}, { message: i18n('validation.IsEnum', { path: 'general', property: 'junior.cardPin' }) })
-  civilIdBackId!: string;
+  cardPin!: string;
 
   @ApiProperty({ example: '123e4567-e89b-12d3-a456-426614174000' })
   @IsUUID('4', { message: i18n('validation.IsUUID', { path: 'general', property: 'customer.profilePictureId' }) })

src/junior/dtos/response/junior.response.dto.ts

@@ -7,10 +7,16 @@ export class JuniorResponseDto {
   @ApiProperty({ example: 'id' })
   id!: string;
 
-  @ApiProperty({ example: 'fullName' })
+  @ApiProperty({ example: 'FirstName' })
-  fullName!: string;
+  firstName!: string;
 
-  @ApiProperty({ example: 'relationship' })
+  @ApiProperty({ example: 'LastName' })
+  lastName!: string;
+
+  @ApiProperty({ example: 'test@junior.com' })
+  email!: string;
+
+  @ApiProperty({ enum: Relationship })
   relationship!: Relationship;
 
   @ApiProperty({ type: DocumentMetaResponseDto })
@@ -18,7 +24,9 @@ export class JuniorResponseDto {
 
   constructor(junior: Junior) {
     this.id = junior.id;
-    this.fullName = `${junior.customer.firstName} ${junior.customer.lastName}`;
+    this.firstName = junior.customer.firstName;
+    this.lastName = junior.customer.lastName;
+    this.email = junior.customer.user.email;
     this.relationship = junior.relationship;
     this.profilePicture = junior.customer.user.profilePicture
       ? new DocumentMetaResponseDto(junior.customer.user.profilePicture)

src/junior/junior.module.ts

@@ -1,6 +1,8 @@
 import { HttpModule } from '@nestjs/axios';
 import { Module } from '@nestjs/common';
 import { TypeOrmModule } from '@nestjs/typeorm';
+import { CardModule } from '~/card/card.module';
+import { NeoLeapModule } from '~/common/modules/neoleap/neoleap.module';
 import { CustomerModule } from '~/customer/customer.module';
 import { UserModule } from '~/user/user.module';
 import { JuniorController } from './controllers';
@@ -11,7 +13,14 @@ import { BranchIoService, JuniorService, QrcodeService } from './services';
 @Module({
   controllers: [JuniorController],
   providers: [JuniorService, JuniorRepository, QrcodeService, BranchIoService],
-  imports: [TypeOrmModule.forFeature([Junior, Theme]), UserModule, CustomerModule, HttpModule],
+  imports: [
+    TypeOrmModule.forFeature([Junior, Theme]),
+    UserModule,
+    CustomerModule,
+    HttpModule,
+    NeoLeapModule,
+    CardModule,
+  ],
   exports: [JuniorService],
 })
 export class JuniorModule {}

src/junior/repositories/junior.repository.ts

@@ -20,7 +20,7 @@ export class JuniorRepository {
   }
 
   findJuniorById(juniorId: string, withGuardianRelation = false, guardianId?: string) {
-    const relations = ['customer', 'customer.user', 'theme', 'theme.avatar'];
+    const relations = ['customer', 'customer.user', 'theme', 'theme.avatar', 'customer.user.profilePicture'];
     if (withGuardianRelation) {
       relations.push('guardian', 'guardian.customer', 'guardian.customer.user');
     }

src/junior/services/junior.service.ts

@@ -1,11 +1,11 @@
 import { BadRequestException, Injectable, Logger } from '@nestjs/common';
-import { FindOptionsWhere } from 'typeorm';
 import { Transactional } from 'typeorm-transactional';
 import { Roles } from '~/auth/enums';
+import { CardService } from '~/card/services';
+import { NeoLeapService } from '~/common/modules/neoleap/services';
 import { PageOptionsRequestDto } from '~/core/dtos';
 import { CustomerService } from '~/customer/services';
 import { DocumentService, OciService } from '~/document/services';
-import { User } from '~/user/entities';
 import { UserType } from '~/user/enums';
 import { UserService } from '~/user/services';
 import { UserTokenService } from '~/user/services/user-token.service';
@@ -25,43 +25,47 @@ export class JuniorService {
     private readonly documentService: DocumentService,
     private readonly ociService: OciService,
     private readonly qrCodeService: QrcodeService,
+    private readonly neoleapService: NeoLeapService,
+    private readonly cardService: CardService,
   ) {}
 
   @Transactional()
   async createJuniors(body: CreateJuniorRequestDto, guardianId: string) {
     this.logger.log(`Creating junior for guardian ${guardianId}`);
 
-    const searchConditions: FindOptionsWhere<User>[] = [{ email: body.email }];
+    const parentCustomer = await this.customerService.findCustomerById(guardianId);
 
-    if (body.phoneNumber && body.countryCode) {
+    if (!parentCustomer.cards || parentCustomer.cards.length === 0) {
-      searchConditions.push({
+      this.logger.error(`Guardian ${guardianId} does not have a card`);
-        phoneNumber: body.phoneNumber,
+      throw new BadRequestException('CUSTOMER.DOES_NOT_HAVE_CARD');
-        countryCode: body.countryCode,
-      });
     }
 
-    const existingUser = await this.userService.findUser(searchConditions);
+    const existingUser = await this.userService.findUser({ email: body.email });
 
     if (existingUser) {
-      this.logger.error(`User with email ${body.email} or phone number ${body.phoneNumber} already exists`);
+      this.logger.error(`User with email ${body.email} already exists`);
       throw new BadRequestException('USER.ALREADY_EXISTS');
     }
 
     const user = await this.userService.createUser({
       email: body.email,
-      countryCode: body.countryCode,
+      firstName: body.firstName,
-      phoneNumber: body.phoneNumber,
+      lastName: body.lastName,
+      profilePictureId: body.profilePictureId,
       roles: [Roles.JUNIOR],
     });
 
-    const customer = await this.customerService.createJuniorCustomer(guardianId, user.id, body);
+    const childCustomer = await this.customerService.createJuniorCustomer(guardianId, user.id, body);
 
     await this.juniorRepository.createJunior(user.id, {
       guardianId,
       relationship: body.relationship,
-      customerId: customer.id,
+      customerId: childCustomer!.id,
     });
 
+    this.logger.debug('Creating card For Child');
+
+    await this.cardService.createCardForChild(parentCustomer, childCustomer!, body.cardColor, body.cardColor);
     this.logger.log(`Junior ${user.id} created successfully`);
 
     return this.generateToken(user.id);
@@ -75,6 +79,7 @@ export class JuniorService {
       this.logger.error(`Junior ${juniorId} not found`);
       throw new BadRequestException('JUNIOR.NOT_FOUND');
     }
+    await this.prepareJuniorImages([junior]);
 
     this.logger.log(`Junior ${juniorId} found successfully`);
     return junior;

src/junior/services/qrcode.service.ts

@@ -10,7 +10,6 @@ export class QrcodeService {
     this.logger.log(`Generating QR code for token ${token}`);
 
     const link = await this.branchIoService.createBranchLink(token);
-
     return qrcode.toDataURL(link);
   }
 }

src/user/services/user.service.ts

@@ -236,13 +236,18 @@ export class UserService {
       throw new BadRequestException('USER.EMAIL_ALREADY_VERIFIED');
     }
 
-    await this.otpService.verifyOtp({
+    const isOtpValid = await this.otpService.verifyOtp({
       userId,
       value: otp,
       scope: OtpScope.VERIFY_EMAIL,
       otpType: OtpType.EMAIL,
     });
 
+    if (!isOtpValid) {
+      this.logger.error(`Invalid OTP for user with email ${user.email}`);
+      throw new BadRequestException('OTP.INVALID_OTP');
+    }
+
     await this.userRepository.update(userId, { isEmailVerified: true });
     this.logger.log(`Email for user ${userId} verified successfully`);
   }