sonar issues

This commit is contained in:
jain
2023-07-17 17:00:33 +05:30
parent 1399b585e8
commit 6d6d21137f
5 changed files with 25 additions and 5 deletions

View File

@ -176,6 +176,7 @@ class SearchTaskListAPIView(viewsets.ModelViewSet):
queryset = self.get_queryset()
paginator = self.pagination_class()
# use pagination
paginated_queryset = paginator.paginate_queryset(queryset, request)
# use TaskSerializer serializer
serializer = TaskDetailsSerializer(paginated_queryset, many=True)
@ -242,6 +243,7 @@ class ApproveTaskAPIView(viewsets.ViewSet):
def get_queryset(self):
"""Get the queryset for the view"""
guardian = Guardian.objects.filter(user__email=self.request.user).last()
# task query
task_queryset = JuniorTask.objects.filter(id=self.request.data.get('task_id'),
guardian=guardian,
junior=self.request.data.get('junior_id')).last()
@ -257,9 +259,11 @@ class ApproveTaskAPIView(viewsets.ViewSet):
"action": str(request.data['action'])},
data=request.data)
if str(request.data['action']) == str(NUMBER['one']) and serializer.is_valid():
# save serializer
serializer.save()
return custom_response(SUCCESS_CODE['3025'], response_status=status.HTTP_200_OK)
elif str(request.data['action']) == str(NUMBER['two']) and serializer.is_valid():
# save serializer
serializer.save()
return custom_response(SUCCESS_CODE['3026'], response_status=status.HTTP_200_OK)
else: