Refactor SidebarCommunitiesList to be a StatelessWidget and update its usage across SpaceTreeView and SidebarWidget for improved performance and maintainability.

This commit is contained in:
Faris Armoush
2025-04-16 14:09:36 +03:00
parent afdd44e098
commit 8b441aaf46
3 changed files with 167 additions and 166 deletions

View File

@ -2,34 +2,19 @@ import 'package:flutter/material.dart';
import 'package:syncrow_web/pages/spaces_management/all_spaces/model/community_model.dart';
import 'package:syncrow_web/utils/extension/build_context_x.dart';
class SidebarCommunitiesList extends StatefulWidget {
class SidebarCommunitiesList extends StatelessWidget {
const SidebarCommunitiesList({
required this.communities,
required this.itemBuilder,
required this.scrollController,
required this.onScrollToEnd,
super.key,
});
final List<CommunityModel> communities;
final Widget Function(BuildContext context, int index) itemBuilder;
@override
State<SidebarCommunitiesList> createState() => _SidebarCommunitiesListState();
}
class _SidebarCommunitiesListState extends State<SidebarCommunitiesList> {
late final ScrollController _scrollController;
@override
void initState() {
_scrollController = ScrollController();
super.initState();
}
@override
void dispose() {
_scrollController.dispose();
super.dispose();
}
final ScrollController scrollController;
final void Function() onScrollToEnd;
@override
Widget build(BuildContext context) {
@ -40,13 +25,22 @@ class _SidebarCommunitiesListState extends State<SidebarCommunitiesList> {
child: Scrollbar(
scrollbarOrientation: ScrollbarOrientation.left,
thumbVisibility: true,
controller: _scrollController,
child: ListView.builder(
padding: const EdgeInsetsDirectional.only(start: 16),
shrinkWrap: true,
itemCount: widget.communities.length,
controller: _scrollController,
itemBuilder: widget.itemBuilder,
controller: scrollController,
child: NotificationListener(
onNotification: (notification) {
if (notification is ScrollEndNotification &&
notification.metrics.extentAfter == 0) {
onScrollToEnd.call();
}
return false;
},
child: ListView.builder(
padding: const EdgeInsetsDirectional.only(start: 16),
shrinkWrap: true,
itemCount: communities.length,
controller: scrollController,
itemBuilder: itemBuilder,
),
),
),
),