fix: refactor device status logging and improve property handling in batch processing

.github/workflows/pr-description.yml

@@ -1,4 +1,4 @@
-name: 🤖 AI PR Description with HuggingFace Falcon
+name: 🤖 AI PR Description Commenter (100% Safe with jq)
 
 on:
   pull_request:
@@ -27,23 +27,26 @@ jobs:
         env:
           GH_TOKEN: ${{ secrets.GH_PERSONAL_TOKEN }}
 
-      - name: Generate PR Description with HuggingFace Falcon
+      - name: Generate PR Description with OpenAI (Safe JSON with jq)
         run: |
           REQUEST_BODY=$(jq -n \
-            --arg inputs "Given the following commit messages:\n\n${commits}\n\nGenerate a clear and professional pull request description." \
+            --arg model "gpt-4o" \
-            '{ inputs: $inputs }'
+            --arg content "Given the following commit messages:\n\n${commits}\n\nGenerate a clear and professional pull request description." \
+            '{
+              model: $model,
+              messages: [{ role: "user", content: $content }]
+            }'
           )
 
-          RESPONSE=$(curl -s https://api-inference.huggingface.co/models/tiiuae/falcon-7b-instruct \
+          RESPONSE=$(curl -s https://api.openai.com/v1/chat/completions \
-            -H "Authorization: Bearer $HUGGINGFACE_API_KEY" \
+            -H "Authorization: Bearer $OPENAI_API_KEY" \
             -H "Content-Type: application/json" \
             -d "$REQUEST_BODY")
 
-          echo "---------- HuggingFace Raw Response ----------"
+          DESCRIPTION=$(echo "$RESPONSE" | jq -r '.choices[0].message.content')
+
+          echo "---------- OpenAI Raw Response ----------"
           echo "$RESPONSE"
-
-          DESCRIPTION=$(echo "$RESPONSE" | jq -r 'if type=="array" then .[0].generated_text else .error else "Error: Unexpected response" end')
-
           echo "---------- Extracted Description ----------"
           echo "$DESCRIPTION"
 
@@ -51,7 +54,7 @@ jobs:
           echo "$DESCRIPTION" >> $GITHUB_ENV
           echo "EOF" >> $GITHUB_ENV
         env:
-          HUGGINGFACE_API_KEY: ${{ secrets.HUGGINGFACE_API_KEY }}
+          OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
           commits: ${{ env.commits }}
 
       - name: Post AI Generated Description as Comment

libs/common/src/firebase/devices-status/services/devices-status.service.ts

@@ -1,15 +1,13 @@
+import { DeviceStatusLogRepository } from '@app/common/modules/device-status-log/repositories';
+import { DeviceRepository } from '@app/common/modules/device/repositories';
 import {
   HttpException,
   HttpStatus,
   Injectable,
   NotFoundException,
 } from '@nestjs/common';
-import { AddDeviceStatusDto } from '../dtos/add.devices-status.dto';
-import { DeviceRepository } from '@app/common/modules/device/repositories';
-import { GetDeviceDetailsFunctionsStatusInterface } from 'src/device/interfaces/get.device.interface';
-import { TuyaContext } from '@tuya/tuya-connector-nodejs';
 import { ConfigService } from '@nestjs/config';
-import { firebaseDataBase } from '../../firebase.config';
+import { TuyaContext } from '@tuya/tuya-connector-nodejs';
 import {
   Database,
   DataSnapshot,
@@ -17,7 +15,9 @@ import {
   ref,
   runTransaction,
 } from 'firebase/database';
-import { DeviceStatusLogRepository } from '@app/common/modules/device-status-log/repositories';
+import { GetDeviceDetailsFunctionsStatusInterface } from 'src/device/interfaces/get.device.interface';
+import { firebaseDataBase } from '../../firebase.config';
+import { AddDeviceStatusDto } from '../dtos/add.devices-status.dto';
 @Injectable()
 export class DeviceStatusFirebaseService {
   private tuya: TuyaContext;
@@ -79,64 +79,77 @@ export class DeviceStatusFirebaseService {
       device: any;
     }[],
   ): Promise<void> {
-    const allLogs = [];
-
     console.log(`🔁 Preparing logs from batch of ${batch.length} items...`);
 
+    const allLogs = [];
+
     for (const item of batch) {
       const device = item.device;
+
       if (!device?.uuid) {
         console.log(`⛔ Skipped unknown device: ${item.deviceTuyaUuid}`);
         continue;
       }
 
-      const logs = item.log.properties.map((property) =>
+      // Determine properties based on environment
+      const properties =
+        this.isDevEnv && Array.isArray(item.log?.properties)
+          ? item.log.properties
+          : Array.isArray(item.status)
+            ? item.status
+            : null;
+
+      if (!properties) {
+        console.log(
+          `⛔ Skipped invalid status/properties for device: ${item.deviceTuyaUuid}`,
+        );
+        continue;
+      }
+
+      const logs = properties.map((property) =>
         this.deviceStatusLogRepository.create({
           deviceId: device.uuid,
           deviceTuyaId: item.deviceTuyaUuid,
-          productId: item.log.productId,
+          productId: device.productDevice?.uuid,
           log: item.log,
           code: property.code,
           value: property.value,
-          eventId: item.log.dataId,
+          eventId: item.log?.dataId,
-          eventTime: new Date(property.time).toISOString(),
+          eventTime: new Date(
+            this.isDevEnv ? property.time : property.t,
+          ).toISOString(),
         }),
       );
+
       allLogs.push(...logs);
     }
 
     console.log(`📝 Total logs to insert: ${allLogs.length}`);
 
-    const insertLogsPromise = (async () => {
+    const chunkSize = 300;
-      const chunkSize = 300;
+    let insertedCount = 0;
-      let insertedCount = 0;
 
-      for (let i = 0; i < allLogs.length; i += chunkSize) {
+    for (let i = 0; i < allLogs.length; i += chunkSize) {
-        const chunk = allLogs.slice(i, i + chunkSize);
+      const chunk = allLogs.slice(i, i + chunkSize);
-        try {
+      try {
-          const result = await this.deviceStatusLogRepository
+        const result = await this.deviceStatusLogRepository
-            .createQueryBuilder()
+          .createQueryBuilder()
-            .insert()
+          .insert()
-            .into('device-status-log') // or use DeviceStatusLogEntity
+          .into('device-status-log')
-            .values(chunk)
+          .values(chunk)
-            .orIgnore() // skip duplicates
+          .orIgnore()
-            .execute();
+          .execute();
 
-          insertedCount += result.identifiers.length;
+        insertedCount += result.identifiers.length;
-          console.log(
+        console.log(
-            `✅ Inserted ${result.identifiers.length} / ${chunk.length} logs (chunk)`,
+          `✅ Inserted ${result.identifiers.length} / ${chunk.length} logs (chunk)`,
-          );
+        );
-        } catch (error) {
+      } catch (error) {
-          console.error('❌ Insert error (skipped chunk):', error.message);
+        console.error('❌ Insert error (skipped chunk):', error.message);
-        }
       }
+    }
 
-      console.log(
+    console.log(`✅ Total logs inserted: ${insertedCount} / ${allLogs.length}`);
-        `✅ Total logs inserted: ${insertedCount} / ${allLogs.length}`,
-      );
-    })();
-
-    await insertLogsPromise;
   }
 
   async addDeviceStatusToFirebase(

libs/common/src/helper/services/tuya.web.socket.service.ts

@@ -1,9 +1,9 @@
-import { Injectable, OnModuleInit } from '@nestjs/common';
-import TuyaWebsocket from '../../config/tuya-web-socket-config';
-import { ConfigService } from '@nestjs/config';
 import { DeviceStatusFirebaseService } from '@app/common/firebase/devices-status/services/devices-status.service';
-import { SosHandlerService } from './sos.handler.service';
+import { Injectable, OnModuleInit } from '@nestjs/common';
+import { ConfigService } from '@nestjs/config';
 import * as NodeCache from 'node-cache';
+import TuyaWebsocket from '../../config/tuya-web-socket-config';
+import { SosHandlerService } from './sos.handler.service';
 
 @Injectable()
 export class TuyaWebSocketService implements OnModuleInit {
@@ -74,7 +74,12 @@ export class TuyaWebSocketService implements OnModuleInit {
     this.client.message(async (ws: WebSocket, message: any) => {
       try {
         const { devId, status, logData } = this.extractMessageData(message);
-        if (!Array.isArray(logData?.properties)) {
+        // console.log(
+        //   `📬 Received message for device: ${devId}, status:`,
+        //   status,
+        //   logData,
+        // );
+        if (!Array.isArray(status)) {
           this.client.ackMessage(message.messageId);
           return;
         }
@@ -162,6 +167,8 @@ export class TuyaWebSocketService implements OnModuleInit {
     status: any;
     logData: any;
   } {
+    // console.log('Received message:', message);
+
     const payloadData = message.payload.data;
 
     if (this.isDevEnv) {

src/weather/controllers/index.ts

@@ -0,0 +1 @@
+export * from './weather.controller';

src/weather/controllers/weather.controller.ts

@@ -0,0 +1,28 @@
+import { Controller, Get, Query } from '@nestjs/common';
+import { ApiOperation, ApiTags } from '@nestjs/swagger';
+import { EnableDisableStatusEnum } from '@app/common/constants/days.enum';
+import { ControllerRoute } from '@app/common/constants/controller-route'; // Assuming this is where the routes are defined
+import { WeatherService } from '../services';
+import { BaseResponseDto } from '@app/common/dto/base.response.dto';
+import { GetWeatherDetailsDto } from '../dto/get.weather.dto';
+
+@ApiTags('Weather Module')
+@Controller({
+  version: EnableDisableStatusEnum.ENABLED,
+  path: ControllerRoute.WEATHER.ROUTE, // use the static route constant
+})
+export class WeatherController {
+  constructor(private readonly weatherService: WeatherService) {}
+
+  @Get()
+  @ApiOperation({
+    summary: ControllerRoute.WEATHER.ACTIONS.FETCH_WEATHER_DETAILS_SUMMARY,
+    description:
+      ControllerRoute.WEATHER.ACTIONS.FETCH_WEATHER_DETAILS_DESCRIPTION,
+  })
+  async fetchWeatherDetails(
+    @Query() query: GetWeatherDetailsDto,
+  ): Promise<BaseResponseDto> {
+    return await this.weatherService.fetchWeatherDetails(query);
+  }
+}

src/weather/dto/get.weather.dto.ts

@@ -0,0 +1,21 @@
+import { ApiProperty } from '@nestjs/swagger';
+import { Type } from 'class-transformer';
+import { IsNumber } from 'class-validator';
+
+export class GetWeatherDetailsDto {
+  @ApiProperty({
+    description: 'Latitude coordinate',
+    example: 35.6895,
+  })
+  @IsNumber()
+  @Type(() => Number)
+  lat: number;
+
+  @ApiProperty({
+    description: 'Longitude coordinate',
+    example: 139.6917,
+  })
+  @IsNumber()
+  @Type(() => Number)
+  lon: number;
+}

src/weather/services/index.ts

@@ -0,0 +1 @@
+export * from './weather.service';

src/weather/services/weather.service.ts

@@ -0,0 +1,51 @@
+import { HttpException, HttpStatus, Injectable } from '@nestjs/common';
+import { HttpService } from '@nestjs/axios';
+import { ConfigService } from '@nestjs/config';
+import { firstValueFrom } from 'rxjs';
+import { GetWeatherDetailsDto } from '../dto/get.weather.dto';
+import { calculateAQI } from '@app/common/util/calculate.aqi';
+import { BaseResponseDto } from '@app/common/dto/base.response.dto';
+import { SuccessResponseDto } from '@app/common/dto/success.response.dto';
+
+@Injectable()
+export class WeatherService {
+  private readonly weatherApiUrl: string;
+  constructor(
+    private readonly configService: ConfigService,
+    private readonly httpService: HttpService,
+  ) {
+    this.weatherApiUrl = this.configService.get<string>('WEATHER_API_URL');
+  }
+
+  async fetchWeatherDetails(
+    query: GetWeatherDetailsDto,
+  ): Promise<BaseResponseDto> {
+    try {
+      const { lat, lon } = query;
+      const weatherApiKey = this.configService.get<string>(
+        'OPEN_WEATHER_MAP_API_KEY',
+      );
+      const url = `${this.weatherApiUrl}/current.json?key=${weatherApiKey}&q=${lat},${lon}&aqi=yes`;
+
+      const response = await firstValueFrom(this.httpService.get(url));
+      const pm2_5 = response.data.current.air_quality.pm2_5; // Raw PM2.5 (µg/m³)
+
+      return new SuccessResponseDto({
+        message: `Weather details fetched successfully`,
+        data: {
+          aqi: calculateAQI(pm2_5), // Converted AQI (0-500)
+          temperature: response.data.current.temp_c,
+          humidity: response.data.current.humidity,
+        },
+        statusCode: HttpStatus.OK,
+      });
+    } catch (error) {
+      console.log(`Error fetching weather data: ${error}`);
+
+      throw new HttpException(
+        `Api can't handle these lat and lon values`,
+        error.response?.status || HttpStatus.INTERNAL_SERVER_ERROR,
+      );
+    }
+  }
+}

src/weather/weather.module.ts

@@ -0,0 +1,12 @@
+import { Module } from '@nestjs/common';
+import { ConfigModule } from '@nestjs/config';
+import { HttpModule } from '@nestjs/axios'; // <-- Import this!
+import { WeatherController } from './controllers';
+import { WeatherService } from './services';
+
+@Module({
+  imports: [ConfigModule, HttpModule],
+  controllers: [WeatherController],
+  providers: [WeatherService],
+})
+export class WeatherModule {}