presence count

libs/common/src/constants/product-type.enum.ts

@@ -15,7 +15,6 @@ export enum ProductType {
   WL = 'WL',
   GD = 'GD',
   CUR = 'CUR',
-  CUR_2 = 'CUR_2',
   PC = 'PC',
   FOUR_S = '4S',
   SIX_S = '6S',

libs/common/src/database/database.module.ts

@@ -125,7 +125,7 @@ import { VisitorPasswordEntity } from '../modules/visitor-password/entities';
           logger: typeOrmLogger,
           extra: {
             charset: 'utf8mb4',
-            max: 50, // set pool max size
+            max: 20, // set pool max size
             idleTimeoutMillis: 5000, // close idle clients after 5 second
             connectionTimeoutMillis: 12_000, // return an error after 11 second if connection could not be established
             maxUses: 7500, // close (and replace) a connection after it has been used 7500 times (see below for discussion)

libs/common/src/sql/procedures/fact_space_occupancy_count/procedure_insert_all_fact_space_occupancy_count.sql

@@ -1,3 +1,4 @@
+-- 1. Load all presence-related logs
 WITH device_logs AS (
     SELECT 
         device.uuid AS device_id,
@@ -15,7 +16,7 @@ WITH device_logs AS (
       AND "device-status-log".code = 'presence_state'
 ),
 
--- 1. All 'none' → presence or motion
+-- 2. Standard transitions: 'none' → 'motion' or 'presence'
 presence_transitions AS (
     SELECT 
         space_id,
@@ -23,10 +24,31 @@ presence_transitions AS (
         event_time::date AS event_date,
         value
     FROM device_logs
-    WHERE (value = 'motion' OR value = 'presence') AND prev_value = 'none'
+    WHERE value IN ('motion', 'presence') AND prev_value = 'none'
 ),
 
--- 2. Cluster events per space_id within 30s
+-- 3. Fallback: days with 'motion' or 'presence' but no 'none'
+fallback_daily_presence AS (
+    SELECT 
+        space_id,
+        event_time::date AS event_date,
+        MIN(event_time) AS event_time,
+        'presence'::text AS value
+    FROM device_logs
+    WHERE value IN ('motion', 'presence', 'none')
+    GROUP BY space_id, event_time::date
+    HAVING BOOL_OR(value = 'motion') OR BOOL_OR(value = 'presence')
+       AND NOT BOOL_OR(value = 'none')
+),
+
+-- 4. Merge both detection sources
+all_presence_events AS (
+    SELECT * FROM presence_transitions
+    UNION ALL
+    SELECT space_id, event_time, event_date, value FROM fallback_daily_presence
+),
+
+-- 5. Cluster events per space_id within 30 seconds
 clustered_events AS (
     SELECT 
         space_id,
@@ -40,11 +62,11 @@ clustered_events AS (
                 WHEN event_time - LAG(event_time) OVER (PARTITION BY space_id ORDER BY event_time) > INTERVAL '30 seconds'
                 THEN 1 ELSE 0
             END AS new_cluster_flag
-        FROM presence_transitions
+        FROM all_presence_events
     ) marked
 ),
 
--- 3. Determine dominant type (motion vs presence) per cluster
+-- 6. Determine dominant type (motion vs presence) per cluster
 cluster_type AS (
     SELECT 
         space_id,
@@ -60,7 +82,7 @@ cluster_type AS (
     GROUP BY space_id, event_date, cluster_id
 ),
 
--- 4. Count clusters by dominant type
+-- 7. Count clusters by dominant type
 summary AS (
     SELECT 
         space_id,
@@ -70,15 +92,16 @@ summary AS (
         COUNT(*) AS count_total_presence_detected
     FROM cluster_type
     GROUP BY space_id, event_date
+),
+
+-- 8. Prepare final result
+final_table AS (
+    SELECT *
+    FROM summary
+    ORDER BY space_id, event_date
 )
 
--- 5. Output
+-- 9. Insert or upsert into the destination table
-, final_table as (
-SELECT *
-FROM summary
-ORDER BY space_id, event_date)
-
-
 INSERT INTO public."presence-sensor-daily-space-detection" (
 	space_uuid,
 	event_date,

libs/common/src/sql/procedures/fact_space_occupancy_count/procedure_update_fact_space_occupancy.sql

@@ -4,6 +4,7 @@ WITH params AS (
       $2::uuid AS space_id
 ),
 
+-- 1. Load logs
 device_logs AS (
     SELECT 
         device.uuid AS device_id,
@@ -21,7 +22,7 @@ device_logs AS (
       AND "device-status-log".code = 'presence_state'
 ),
 
--- 1. All 'none' → presence or motion
+-- 2. Transitions from 'none' → motion/presence
 presence_transitions AS (
     SELECT 
         space_id,
@@ -29,10 +30,30 @@ presence_transitions AS (
         event_time::date AS event_date,
         value
     FROM device_logs
-    WHERE (value = 'motion' OR value = 'presence') AND prev_value = 'none'
+    WHERE value IN ('motion', 'presence') AND prev_value = 'none'
 ),
 
--- 2. Cluster events per space_id within 30s
+-- 3. Fallback: days with motion/presence but no 'none'
+fallback_daily_presence AS (
+    SELECT 
+        space_id,
+        event_time::date AS event_date,
+        MIN(event_time) AS event_time,
+        'presence'::text AS value
+    FROM device_logs
+    GROUP BY space_id, event_time::date
+    HAVING BOOL_OR(value = 'motion') OR BOOL_OR(value = 'presence')
+       AND NOT BOOL_OR(value = 'none')
+),
+
+-- 4. Combine standard and fallback detections
+all_presence_events AS (
+    SELECT * FROM presence_transitions
+    UNION ALL
+    SELECT * FROM fallback_daily_presence
+),
+
+-- 5. Cluster detections (within 30s)
 clustered_events AS (
     SELECT 
         space_id,
@@ -46,11 +67,11 @@ clustered_events AS (
                 WHEN event_time - LAG(event_time) OVER (PARTITION BY space_id ORDER BY event_time) > INTERVAL '30 seconds'
                 THEN 1 ELSE 0
             END AS new_cluster_flag
-        FROM presence_transitions
+        FROM all_presence_events
     ) marked
 ),
 
--- 3. Determine dominant type (motion vs presence) per cluster
+-- 6. Dominant type per cluster
 cluster_type AS (
     SELECT 
         space_id,
@@ -66,7 +87,7 @@ cluster_type AS (
     GROUP BY space_id, event_date, cluster_id
 ),
 
--- 4. Count clusters by dominant type
+-- 7. Count presence by type
 summary AS (
     SELECT 
         space_id,
@@ -76,22 +97,22 @@ summary AS (
         COUNT(*) AS count_total_presence_detected
     FROM cluster_type
     GROUP BY space_id, event_date
+),
+
+-- 8. Filter by params and return final table
+final_table AS (
+    SELECT 
+        summary.space_id,
+        summary.event_date,
+        count_motion_detected,
+        count_presence_detected,
+        count_total_presence_detected
+    FROM summary
+    JOIN params p ON summary.space_id = p.space_id
+    WHERE p.event_date IS NULL OR summary.event_date = p.event_date
 )
 
--- 5. Output
+-- 9. Insert or upsert into the table
-, final_table as (
-SELECT summary.space_id,
-       summary.event_date,
-       count_motion_detected,
-       count_presence_detected,
-       count_total_presence_detected
-FROM summary
-JOIN params P ON true
-where summary.space_id = P.space_id
-and (P.event_date IS NULL or summary.event_date::date = P.event_date)
-ORDER BY space_id, event_date)
-
-
 INSERT INTO public."presence-sensor-daily-space-detection" (
 	space_uuid,
 	event_date,

libs/common/src/sql/queries/fact_hourly_space_presence_detected/fact_hourly_space_presence_detected.sql

@@ -30,6 +30,19 @@ presence_detection AS (
     FROM device_logs
 ),
 
+fallback_daily_presence AS (
+    SELECT 
+        space_id,
+        event_time::date AS event_date,
+        0 AS event_hour,
+        COUNT(*) > 0 AS has_presence,
+        BOOL_OR(value = 'none') AS has_none
+    FROM device_logs
+    WHERE value IN ('motion', 'presence', 'none')
+    GROUP BY space_id, event_time::date
+    HAVING COUNT(*) > 0 AND NOT BOOL_OR(value = 'none')
+),
+
 space_level_presence_events AS (
     SELECT DISTINCT 
         pd.space_id,
@@ -38,6 +51,15 @@ space_level_presence_events AS (
         pd.event_time
     FROM presence_detection pd
     WHERE presence_started = 1
+
+    UNION
+
+    SELECT 
+        fdp.space_id,
+        fdp.event_date,
+        fdp.event_hour,
+        NULL::timestamp AS event_time
+    FROM fallback_daily_presence fdp
 ),
 
 space_level_presence_summary AS (
@@ -77,3 +99,4 @@ LEFT JOIN space_level_presence_summary pds
 ORDER BY space_id, event_date, event_hour;
 
 
+

src/community/services/community.service.ts

@@ -190,26 +190,24 @@ export class CommunityService {
         .distinct(true);
 
       if (includeSpaces) {
-        qb.leftJoinAndSelect(
+        qb.leftJoinAndSelect('c.spaces', 'space', 'space.disabled = false')
-          'c.spaces',
-          'space',
-          'space.disabled = :disabled AND space.spaceName != :orphanSpaceName',
-          { disabled: false, orphanSpaceName: ORPHAN_SPACE_NAME },
-        )
           .leftJoinAndSelect('space.parent', 'parent')
           .leftJoinAndSelect(
             'space.children',
             'children',
             'children.disabled = :disabled',
             { disabled: false },
-          );
+          )
-        // .leftJoinAndSelect('space.spaceModel', 'spaceModel')
+          // .leftJoinAndSelect('space.spaceModel', 'spaceModel')
+          .andWhere('space.spaceName != :orphanSpaceName', {
+            orphanSpaceName: ORPHAN_SPACE_NAME,
+          })
+          .andWhere('space.disabled = :disabled', { disabled: false });
       }
 
       if (search) {
         qb.andWhere(
-          `c.name ILIKE :search ${includeSpaces ? 'OR space.space_name ILIKE :search' : ''}`,
+          `c.name ILIKE '%${search}%' ${includeSpaces ? "OR space.space_name ILIKE '%" + search + "%'" : ''}`,
-          { search },
         );
       }
 
@@ -217,21 +215,12 @@ export class CommunityService {
 
       const { baseResponseDto, paginationResponseDto } =
         await customModel.findAll({ ...pageable, modelName: 'community' }, qb);
-      if (includeSpaces) {
-        baseResponseDto.data = baseResponseDto.data.map((community) => ({
-          ...community,
-          spaces: this.spaceService.buildSpaceHierarchy(community.spaces || []),
-        }));
-      }
       return new PageResponse<CommunityDto>(
         baseResponseDto,
         paginationResponseDto,
       );
     } catch (error) {
       // Generic error handling
-      if (error instanceof HttpException) {
-        throw error;
-      }
       throw new HttpException(
         error.message || 'An error occurred while fetching communities.',
         HttpStatus.INTERNAL_SERVER_ERROR,

src/device/commands/cur2-commands.ts

@@ -1,28 +0,0 @@
-interface BaseCommand {
-  code: string;
-  value: any;
-}
-export interface ControlCur2Command extends BaseCommand {
-  code: 'control';
-  value: 'open' | 'close' | 'stop';
-}
-export interface ControlCur2PercentCommand extends BaseCommand {
-  code: 'percent_control';
-  value: 10 | 20 | 30 | 40 | 50 | 60 | 70 | 80 | 90 | 100;
-}
-export interface ControlCur2AccurateCalibrationCommand extends BaseCommand {
-  code: 'accurate_calibration';
-  value: 'start' | 'end'; // Assuming this is a numeric value for calibration
-}
-export interface ControlCur2TDirectionConCommand extends BaseCommand {
-  code: 'control_t_direction_con';
-  value: 'forward' | 'back';
-}
-export interface ControlCur2QuickCalibrationCommand extends BaseCommand {
-  code: 'tr_timecon';
-  value: number; // between 10 and 120
-}
-export interface ControlCur2MotorModeCommand extends BaseCommand {
-  code: 'elec_machinery_mode';
-  value: 'strong_power' | 'dry_contact';
-}

src/device/controllers/device-project.controller.ts

@@ -1,11 +1,11 @@
-import { ControllerRoute } from '@app/common/constants/controller-route';
-import { EnableDisableStatusEnum } from '@app/common/constants/days.enum';
-import { Controller, Get, Param, Query, UseGuards } from '@nestjs/common';
-import { ApiBearerAuth, ApiOperation, ApiTags } from '@nestjs/swagger';
-import { Permissions } from 'src/decorators/permissions.decorator';
-import { PermissionsGuard } from 'src/guards/permissions.guard';
-import { GetDevicesFilterDto, ProjectParam } from '../dtos';
 import { DeviceService } from '../services/device.service';
+import { Controller, Get, Param, Query, UseGuards } from '@nestjs/common';
+import { ApiTags, ApiBearerAuth, ApiOperation } from '@nestjs/swagger';
+import { EnableDisableStatusEnum } from '@app/common/constants/days.enum';
+import { ControllerRoute } from '@app/common/constants/controller-route';
+import { PermissionsGuard } from 'src/guards/permissions.guard';
+import { Permissions } from 'src/decorators/permissions.decorator';
+import { GetDoorLockDevices, ProjectParam } from '../dtos';
 
 @ApiTags('Device Module')
 @Controller({
@@ -25,7 +25,7 @@ export class DeviceProjectController {
   })
   async getAllDevices(
     @Param() param: ProjectParam,
-    @Query() query: GetDevicesFilterDto,
+    @Query() query: GetDoorLockDevices,
   ) {
     return await this.deviceService.getAllDevices(param, query);
   }

src/device/dtos/get.device.dto.ts

@@ -1,7 +1,6 @@
 import { DeviceTypeEnum } from '@app/common/constants/device-type.enum';
 import { ApiProperty } from '@nestjs/swagger';
 import {
-  IsArray,
   IsEnum,
   IsNotEmpty,
   IsOptional,
@@ -42,7 +41,16 @@ export class GetDeviceLogsDto {
   @IsOptional()
   public endTime: string;
 }
-
+export class GetDoorLockDevices {
+  @ApiProperty({
+    description: 'Device Type',
+    enum: DeviceTypeEnum,
+    required: false,
+  })
+  @IsEnum(DeviceTypeEnum)
+  @IsOptional()
+  public deviceType: DeviceTypeEnum;
+}
 export class GetDevicesBySpaceOrCommunityDto {
   @ApiProperty({
     description: 'Device Product Type',
@@ -64,23 +72,3 @@ export class GetDevicesBySpaceOrCommunityDto {
   @IsNotEmpty({ message: 'Either spaceUuid or communityUuid must be provided' })
   requireEither?: never; // This ensures at least one of them is provided
 }
-
-export class GetDevicesFilterDto {
-  @ApiProperty({
-    description: 'Device Type',
-    enum: DeviceTypeEnum,
-    required: false,
-  })
-  @IsEnum(DeviceTypeEnum)
-  @IsOptional()
-  public deviceType: DeviceTypeEnum;
-  @ApiProperty({
-    description: 'List of Space IDs to filter devices',
-    required: false,
-    example: ['60d21b4667d0d8992e610c85', '60d21b4967d0d8992e610c86'],
-  })
-  @IsOptional()
-  @IsArray()
-  @IsUUID('4', { each: true })
-  public spaces?: string[];
-}

src/device/services/device.service.ts

@@ -53,7 +53,7 @@ import { DeviceSceneParamDto } from '../dtos/device.param.dto';
 import {
   GetDeviceLogsDto,
   GetDevicesBySpaceOrCommunityDto,
-  GetDevicesFilterDto,
+  GetDoorLockDevices,
 } from '../dtos/get.device.dto';
 import {
   controlDeviceInterface,
@@ -955,20 +955,19 @@ export class DeviceService {
 
   async getAllDevices(
     param: ProjectParam,
-    { deviceType, spaces }: GetDevicesFilterDto,
+    query: GetDoorLockDevices,
   ): Promise<BaseResponseDto> {
     try {
       await this.validateProject(param.projectUuid);
-      if (deviceType === DeviceTypeEnum.DOOR_LOCK) {
+      if (query.deviceType === DeviceTypeEnum.DOOR_LOCK) {
-        return await this.getDoorLockDevices(param.projectUuid, spaces);
+        return await this.getDoorLockDevices(param.projectUuid);
-      } else if (!deviceType) {
+      } else if (!query.deviceType) {
         const devices = await this.deviceRepository.find({
           where: {
             isActive: true,
             spaceDevice: {
-              uuid: spaces && spaces.length ? In(spaces) : undefined,
-              spaceName: Not(ORPHAN_SPACE_NAME),
               community: { project: { uuid: param.projectUuid } },
+              spaceName: Not(ORPHAN_SPACE_NAME),
             },
           },
           relations: [
@@ -1564,7 +1563,7 @@ export class DeviceService {
     }
   }
 
-  async getDoorLockDevices(projectUuid: string, spaces?: string[]) {
+  async getDoorLockDevices(projectUuid: string) {
     await this.validateProject(projectUuid);
 
     const devices = await this.deviceRepository.find({
@@ -1574,7 +1573,6 @@ export class DeviceService {
         },
         spaceDevice: {
           spaceName: Not(ORPHAN_SPACE_NAME),
-          uuid: spaces && spaces.length ? In(spaces) : undefined,
           community: {
             project: {
               uuid: projectUuid,

src/main.ts

@@ -26,6 +26,8 @@ async function bootstrap() {
     rateLimit({
       windowMs: 5 * 60 * 1000,
       max: 500,
+      standardHeaders: true,
+      legacyHeaders: false,
     }),
   );
 
@@ -34,7 +36,7 @@ async function bootstrap() {
     next();
   });
 
-  // app.getHttpAdapter().getInstance().set('trust proxy', 1);
+  app.getHttpAdapter().getInstance().set('trust proxy', 1);
 
   app.use(
     helmet({

src/schedule/constants/device-function-map.ts

@@ -1,32 +0,0 @@
-import {
-  ControlCur2AccurateCalibrationCommand,
-  ControlCur2Command,
-  ControlCur2PercentCommand,
-  ControlCur2QuickCalibrationCommand,
-  ControlCur2TDirectionConCommand,
-} from 'src/device/commands/cur2-commands';
-
-export enum ScheduleProductType {
-  CUR_2 = 'CUR_2',
-}
-export const DeviceFunctionMap: {
-  [T in ScheduleProductType]: (body: DeviceFunction[T]) => any;
-} = {
-  [ScheduleProductType.CUR_2]: ({ code, value }) => {
-    return [
-      {
-        code,
-        value,
-      },
-    ];
-  },
-};
-
-type DeviceFunction = {
-  [ScheduleProductType.CUR_2]:
-    | ControlCur2Command
-    | ControlCur2PercentCommand
-    | ControlCur2AccurateCalibrationCommand
-    | ControlCur2TDirectionConCommand
-    | ControlCur2QuickCalibrationCommand;
-};

src/schedule/services/schedule.service.ts

@@ -1,6 +1,6 @@
-import { HttpException, HttpStatus, Injectable } from '@nestjs/common';
+import { Injectable, HttpException, HttpStatus } from '@nestjs/common';
-import { ConfigService } from '@nestjs/config';
 import { TuyaContext } from '@tuya/tuya-connector-nodejs';
+import { ConfigService } from '@nestjs/config';
 import {
   AddScheduleDto,
   EnableScheduleDto,
@@ -11,14 +11,14 @@ import {
   getDeviceScheduleInterface,
 } from '../interfaces/get.schedule.interface';
 
-import { ProductType } from '@app/common/constants/product-type.enum';
 import { convertKeysToCamelCase } from '@app/common/helper/camelCaseConverter';
+import { DeviceRepository } from '@app/common/modules/device/repositories';
+import { ProductType } from '@app/common/constants/product-type.enum';
 import { convertTimestampToDubaiTime } from '@app/common/helper/convertTimestampToDubaiTime';
 import {
   getEnabledDays,
   getScheduleStatus,
 } from '@app/common/helper/getScheduleStatus';
-import { DeviceRepository } from '@app/common/modules/device/repositories';
 
 @Injectable()
 export class ScheduleService {
@@ -49,11 +49,22 @@ export class ScheduleService {
       }
 
       // Corrected condition for supported device types
-      this.ensureProductTypeSupportedForSchedule(
+      if (
-        ProductType[deviceDetails.productDevice.prodType],
+        deviceDetails.productDevice.prodType !== ProductType.THREE_G &&
-      );
+        deviceDetails.productDevice.prodType !== ProductType.ONE_G &&
-
+        deviceDetails.productDevice.prodType !== ProductType.TWO_G &&
-      return this.enableScheduleDeviceInTuya(
+        deviceDetails.productDevice.prodType !== ProductType.WH &&
+        deviceDetails.productDevice.prodType !== ProductType.ONE_1TG &&
+        deviceDetails.productDevice.prodType !== ProductType.TWO_2TG &&
+        deviceDetails.productDevice.prodType !== ProductType.THREE_3TG &&
+        deviceDetails.productDevice.prodType !== ProductType.GD
+      ) {
+        throw new HttpException(
+          'This device is not supported for schedule',
+          HttpStatus.BAD_REQUEST,
+        );
+      }
+      return await this.enableScheduleDeviceInTuya(
         deviceDetails.deviceTuyaUuid,
         enableScheduleDto,
       );
@@ -64,6 +75,29 @@ export class ScheduleService {
       );
     }
   }
+  async enableScheduleDeviceInTuya(
+    deviceId: string,
+    enableScheduleDto: EnableScheduleDto,
+  ): Promise<addScheduleDeviceInterface> {
+    try {
+      const path = `/v2.0/cloud/timer/device/${deviceId}/state`;
+      const response = await this.tuya.request({
+        method: 'PUT',
+        path,
+        body: {
+          enable: enableScheduleDto.enable,
+          timer_id: enableScheduleDto.scheduleId,
+        },
+      });
+
+      return response as addScheduleDeviceInterface;
+    } catch (error) {
+      throw new HttpException(
+        'Error while updating schedule from Tuya',
+        HttpStatus.INTERNAL_SERVER_ERROR,
+      );
+    }
+  }
   async deleteDeviceSchedule(deviceUuid: string, scheduleId: string) {
     try {
       const deviceDetails = await this.getDeviceByDeviceUuid(deviceUuid);
@@ -73,10 +107,21 @@ export class ScheduleService {
       }
 
       // Corrected condition for supported device types
-      this.ensureProductTypeSupportedForSchedule(
+      if (
-        ProductType[deviceDetails.productDevice.prodType],
+        deviceDetails.productDevice.prodType !== ProductType.THREE_G &&
-      );
+        deviceDetails.productDevice.prodType !== ProductType.ONE_G &&
-
+        deviceDetails.productDevice.prodType !== ProductType.TWO_G &&
+        deviceDetails.productDevice.prodType !== ProductType.WH &&
+        deviceDetails.productDevice.prodType !== ProductType.ONE_1TG &&
+        deviceDetails.productDevice.prodType !== ProductType.TWO_2TG &&
+        deviceDetails.productDevice.prodType !== ProductType.THREE_3TG &&
+        deviceDetails.productDevice.prodType !== ProductType.GD
+      ) {
+        throw new HttpException(
+          'This device is not supported for schedule',
+          HttpStatus.BAD_REQUEST,
+        );
+      }
       return await this.deleteScheduleDeviceInTuya(
         deviceDetails.deviceTuyaUuid,
         scheduleId,
@@ -88,6 +133,25 @@ export class ScheduleService {
       );
     }
   }
+  async deleteScheduleDeviceInTuya(
+    deviceId: string,
+    scheduleId: string,
+  ): Promise<addScheduleDeviceInterface> {
+    try {
+      const path = `/v2.0/cloud/timer/device/${deviceId}/batch?timer_ids=${scheduleId}`;
+      const response = await this.tuya.request({
+        method: 'DELETE',
+        path,
+      });
+
+      return response as addScheduleDeviceInterface;
+    } catch (error) {
+      throw new HttpException(
+        'Error while deleting schedule from Tuya',
+        HttpStatus.INTERNAL_SERVER_ERROR,
+      );
+    }
+  }
   async addDeviceSchedule(deviceUuid: string, addScheduleDto: AddScheduleDto) {
     try {
       const deviceDetails = await this.getDeviceByDeviceUuid(deviceUuid);
@@ -96,10 +160,22 @@ export class ScheduleService {
         throw new HttpException('Device Not Found', HttpStatus.NOT_FOUND);
       }
 
-      this.ensureProductTypeSupportedForSchedule(
+      // Corrected condition for supported device types
-        ProductType[deviceDetails.productDevice.prodType],
+      if (
-      );
+        deviceDetails.productDevice.prodType !== ProductType.THREE_G &&
-
+        deviceDetails.productDevice.prodType !== ProductType.ONE_G &&
+        deviceDetails.productDevice.prodType !== ProductType.TWO_G &&
+        deviceDetails.productDevice.prodType !== ProductType.WH &&
+        deviceDetails.productDevice.prodType !== ProductType.ONE_1TG &&
+        deviceDetails.productDevice.prodType !== ProductType.TWO_2TG &&
+        deviceDetails.productDevice.prodType !== ProductType.THREE_3TG &&
+        deviceDetails.productDevice.prodType !== ProductType.GD
+      ) {
+        throw new HttpException(
+          'This device is not supported for schedule',
+          HttpStatus.BAD_REQUEST,
+        );
+      }
       await this.addScheduleDeviceInTuya(
         deviceDetails.deviceTuyaUuid,
         addScheduleDto,
@@ -111,6 +187,40 @@ export class ScheduleService {
       );
     }
   }
+  async addScheduleDeviceInTuya(
+    deviceId: string,
+    addScheduleDto: AddScheduleDto,
+  ): Promise<addScheduleDeviceInterface> {
+    try {
+      const convertedTime = convertTimestampToDubaiTime(addScheduleDto.time);
+      const loops = getScheduleStatus(addScheduleDto.days);
+
+      const path = `/v2.0/cloud/timer/device/${deviceId}`;
+      const response = await this.tuya.request({
+        method: 'POST',
+        path,
+        body: {
+          time: convertedTime.time,
+          timezone_id: 'Asia/Dubai',
+          loops: `${loops}`,
+          functions: [
+            {
+              code: addScheduleDto.function.code,
+              value: addScheduleDto.function.value,
+            },
+          ],
+          category: `category_${addScheduleDto.category}`,
+        },
+      });
+
+      return response as addScheduleDeviceInterface;
+    } catch (error) {
+      throw new HttpException(
+        'Error adding schedule from Tuya',
+        HttpStatus.INTERNAL_SERVER_ERROR,
+      );
+    }
+  }
   async getDeviceScheduleByCategory(deviceUuid: string, category: string) {
     try {
       const deviceDetails = await this.getDeviceByDeviceUuid(deviceUuid);
@@ -119,10 +229,21 @@ export class ScheduleService {
         throw new HttpException('Device Not Found', HttpStatus.NOT_FOUND);
       }
       // Corrected condition for supported device types
-      this.ensureProductTypeSupportedForSchedule(
+      if (
-        ProductType[deviceDetails.productDevice.prodType],
+        deviceDetails.productDevice.prodType !== ProductType.THREE_G &&
-      );
+        deviceDetails.productDevice.prodType !== ProductType.ONE_G &&
-
+        deviceDetails.productDevice.prodType !== ProductType.TWO_G &&
+        deviceDetails.productDevice.prodType !== ProductType.WH &&
+        deviceDetails.productDevice.prodType !== ProductType.ONE_1TG &&
+        deviceDetails.productDevice.prodType !== ProductType.TWO_2TG &&
+        deviceDetails.productDevice.prodType !== ProductType.THREE_3TG &&
+        deviceDetails.productDevice.prodType !== ProductType.GD
+      ) {
+        throw new HttpException(
+          'This device is not supported for schedule',
+          HttpStatus.BAD_REQUEST,
+        );
+      }
       const schedules = await this.getScheduleDeviceInTuya(
         deviceDetails.deviceTuyaUuid,
         category,
@@ -149,82 +270,7 @@ export class ScheduleService {
       );
     }
   }
-  async updateDeviceSchedule(
+  async getScheduleDeviceInTuya(
-    deviceUuid: string,
-    updateScheduleDto: UpdateScheduleDto,
-  ) {
-    try {
-      const deviceDetails = await this.getDeviceByDeviceUuid(deviceUuid);
-
-      if (!deviceDetails || !deviceDetails.deviceTuyaUuid) {
-        throw new HttpException('Device Not Found', HttpStatus.NOT_FOUND);
-      }
-
-      // Corrected condition for supported device types
-      this.ensureProductTypeSupportedForSchedule(
-        ProductType[deviceDetails.productDevice.prodType],
-      );
-
-      await this.updateScheduleDeviceInTuya(
-        deviceDetails.deviceTuyaUuid,
-        updateScheduleDto,
-      );
-    } catch (error) {
-      throw new HttpException(
-        error.message || 'Error While Updating Schedule',
-        error.status || HttpStatus.INTERNAL_SERVER_ERROR,
-      );
-    }
-  }
-
-  private getDeviceByDeviceUuid(
-    deviceUuid: string,
-    withProductDevice: boolean = true,
-  ) {
-    return this.deviceRepository.findOne({
-      where: {
-        uuid: deviceUuid,
-        isActive: true,
-      },
-      ...(withProductDevice && { relations: ['productDevice'] }),
-    });
-  }
-
-  private async addScheduleDeviceInTuya(
-    deviceId: string,
-    addScheduleDto: AddScheduleDto,
-  ): Promise<addScheduleDeviceInterface> {
-    try {
-      const convertedTime = convertTimestampToDubaiTime(addScheduleDto.time);
-      const loops = getScheduleStatus(addScheduleDto.days);
-
-      const path = `/v2.0/cloud/timer/device/${deviceId}`;
-      const response = await this.tuya.request({
-        method: 'POST',
-        path,
-        body: {
-          time: convertedTime.time,
-          timezone_id: 'Asia/Dubai',
-          loops: `${loops}`,
-          functions: [
-            {
-              ...addScheduleDto.function,
-            },
-          ],
-          category: `category_${addScheduleDto.category}`,
-        },
-      });
-
-      return response as addScheduleDeviceInterface;
-    } catch (error) {
-      throw new HttpException(
-        'Error adding schedule from Tuya',
-        HttpStatus.INTERNAL_SERVER_ERROR,
-      );
-    }
-  }
-
-  private async getScheduleDeviceInTuya(
     deviceId: string,
     category: string,
   ): Promise<getDeviceScheduleInterface> {
@@ -245,8 +291,57 @@ export class ScheduleService {
       );
     }
   }
+  async getDeviceByDeviceUuid(
+    deviceUuid: string,
+    withProductDevice: boolean = true,
+  ) {
+    return await this.deviceRepository.findOne({
+      where: {
+        uuid: deviceUuid,
+        isActive: true,
+      },
+      ...(withProductDevice && { relations: ['productDevice'] }),
+    });
+  }
+  async updateDeviceSchedule(
+    deviceUuid: string,
+    updateScheduleDto: UpdateScheduleDto,
+  ) {
+    try {
+      const deviceDetails = await this.getDeviceByDeviceUuid(deviceUuid);
 
-  private async updateScheduleDeviceInTuya(
+      if (!deviceDetails || !deviceDetails.deviceTuyaUuid) {
+        throw new HttpException('Device Not Found', HttpStatus.NOT_FOUND);
+      }
+
+      // Corrected condition for supported device types
+      if (
+        deviceDetails.productDevice.prodType !== ProductType.THREE_G &&
+        deviceDetails.productDevice.prodType !== ProductType.ONE_G &&
+        deviceDetails.productDevice.prodType !== ProductType.TWO_G &&
+        deviceDetails.productDevice.prodType !== ProductType.WH &&
+        deviceDetails.productDevice.prodType !== ProductType.ONE_1TG &&
+        deviceDetails.productDevice.prodType !== ProductType.TWO_2TG &&
+        deviceDetails.productDevice.prodType !== ProductType.THREE_3TG &&
+        deviceDetails.productDevice.prodType !== ProductType.GD
+      ) {
+        throw new HttpException(
+          'This device is not supported for schedule',
+          HttpStatus.BAD_REQUEST,
+        );
+      }
+      await this.updateScheduleDeviceInTuya(
+        deviceDetails.deviceTuyaUuid,
+        updateScheduleDto,
+      );
+    } catch (error) {
+      throw new HttpException(
+        error.message || 'Error While Updating Schedule',
+        error.status || HttpStatus.INTERNAL_SERVER_ERROR,
+      );
+    }
+  }
+  async updateScheduleDeviceInTuya(
     deviceId: string,
     updateScheduleDto: UpdateScheduleDto,
   ): Promise<addScheduleDeviceInterface> {
@@ -281,69 +376,4 @@ export class ScheduleService {
       );
     }
   }
-
-  private async enableScheduleDeviceInTuya(
-    deviceId: string,
-    enableScheduleDto: EnableScheduleDto,
-  ): Promise<addScheduleDeviceInterface> {
-    try {
-      const path = `/v2.0/cloud/timer/device/${deviceId}/state`;
-      const response = await this.tuya.request({
-        method: 'PUT',
-        path,
-        body: {
-          enable: enableScheduleDto.enable,
-          timer_id: enableScheduleDto.scheduleId,
-        },
-      });
-
-      return response as addScheduleDeviceInterface;
-    } catch (error) {
-      throw new HttpException(
-        'Error while updating schedule from Tuya',
-        HttpStatus.INTERNAL_SERVER_ERROR,
-      );
-    }
-  }
-
-  private async deleteScheduleDeviceInTuya(
-    deviceId: string,
-    scheduleId: string,
-  ): Promise<addScheduleDeviceInterface> {
-    try {
-      const path = `/v2.0/cloud/timer/device/${deviceId}/batch?timer_ids=${scheduleId}`;
-      const response = await this.tuya.request({
-        method: 'DELETE',
-        path,
-      });
-
-      return response as addScheduleDeviceInterface;
-    } catch (error) {
-      throw new HttpException(
-        'Error while deleting schedule from Tuya',
-        HttpStatus.INTERNAL_SERVER_ERROR,
-      );
-    }
-  }
-
-  private ensureProductTypeSupportedForSchedule(deviceType: ProductType): void {
-    if (
-      ![
-        ProductType.THREE_G,
-        ProductType.ONE_G,
-        ProductType.TWO_G,
-        ProductType.WH,
-        ProductType.ONE_1TG,
-        ProductType.TWO_2TG,
-        ProductType.THREE_3TG,
-        ProductType.GD,
-        ProductType.CUR_2,
-      ].includes(deviceType)
-    ) {
-      throw new HttpException(
-        'This device is not supported for schedule',
-        HttpStatus.BAD_REQUEST,
-      );
-    }
-  }
 }

src/space/services/space.service.ts

@@ -681,7 +681,7 @@ export class SpaceService {
     }
   }
 
-  buildSpaceHierarchy(spaces: SpaceEntity[]): SpaceEntity[] {
+  private buildSpaceHierarchy(spaces: SpaceEntity[]): SpaceEntity[] {
     const map = new Map<string, SpaceEntity>();
 
     // Step 1: Create a map of spaces by UUID