Refactor controllers to return UUID of added entities

This commit is contained in:
faris Aljohari
2024-05-01 10:34:07 +03:00
parent 229909f959
commit d146cce1bb
10 changed files with 21 additions and 15 deletions
@@ -32,8 +32,8 @@ export class BuildingController {
@Post() @Post()
async addBuilding(@Body() addBuildingDto: AddBuildingDto) { async addBuilding(@Body() addBuildingDto: AddBuildingDto) {
try { try {
await this.buildingService.addBuilding(addBuildingDto); const building = await this.buildingService.addBuilding(addBuildingDto);
return { message: 'Building added successfully' }; return { message: 'Building added successfully', uuid: building.uuid };
} catch (error) { } catch (error) {
throw new HttpException( throw new HttpException(
error.message || 'Internal server error', error.message || 'Internal server error',
+2 -1
View File
@@ -38,11 +38,12 @@ export class BuildingService {
if (!spaceType) { if (!spaceType) {
throw new BadRequestException('Invalid building UUID'); throw new BadRequestException('Invalid building UUID');
} }
await this.spaceRepository.save({ const building = await this.spaceRepository.save({
spaceName: addBuildingDto.buildingName, spaceName: addBuildingDto.buildingName,
parent: { uuid: addBuildingDto.communityUuid }, parent: { uuid: addBuildingDto.communityUuid },
spaceType: { uuid: spaceType.uuid }, spaceType: { uuid: spaceType.uuid },
}); });
return building;
} catch (err) { } catch (err) {
if (err instanceof BadRequestException) { if (err instanceof BadRequestException) {
throw err; // Re-throw BadRequestException throw err; // Re-throw BadRequestException
@@ -34,8 +34,9 @@ export class CommunityController {
@Post() @Post()
async addCommunity(@Body() addCommunityDto: AddCommunityDto) { async addCommunity(@Body() addCommunityDto: AddCommunityDto) {
try { try {
await this.communityService.addCommunity(addCommunityDto); const community =
return { message: 'Community added successfully' }; await this.communityService.addCommunity(addCommunityDto);
return { message: 'Community added successfully', uuid: community.uuid };
} catch (error) { } catch (error) {
throw new HttpException( throw new HttpException(
error.message || 'Internal server error', error.message || 'Internal server error',
+2 -1
View File
@@ -34,10 +34,11 @@ export class CommunityService {
}, },
}); });
await this.spaceRepository.save({ const community = await this.spaceRepository.save({
spaceName: addCommunityDto.communityName, spaceName: addCommunityDto.communityName,
spaceType: { uuid: spaceType.uuid }, spaceType: { uuid: spaceType.uuid },
}); });
return community;
} catch (err) { } catch (err) {
throw new HttpException(err.message, HttpStatus.INTERNAL_SERVER_ERROR); throw new HttpException(err.message, HttpStatus.INTERNAL_SERVER_ERROR);
} }
+2 -2
View File
@@ -32,8 +32,8 @@ export class FloorController {
@Post() @Post()
async addFloor(@Body() addFloorDto: AddFloorDto) { async addFloor(@Body() addFloorDto: AddFloorDto) {
try { try {
await this.floorService.addFloor(addFloorDto); const floor = await this.floorService.addFloor(addFloorDto);
return { message: 'Floor added successfully' }; return { message: 'Floor added successfully', uuid: floor.uuid };
} catch (error) { } catch (error) {
throw new HttpException( throw new HttpException(
error.message || 'Internal server error', error.message || 'Internal server error',
+2 -1
View File
@@ -35,11 +35,12 @@ export class FloorService {
}, },
}); });
await this.spaceRepository.save({ const floor = await this.spaceRepository.save({
spaceName: addFloorDto.floorName, spaceName: addFloorDto.floorName,
parent: { uuid: addFloorDto.buildingUuid }, parent: { uuid: addFloorDto.buildingUuid },
spaceType: { uuid: spaceType.uuid }, spaceType: { uuid: spaceType.uuid },
}); });
return floor;
} catch (err) { } catch (err) {
throw new HttpException(err.message, HttpStatus.INTERNAL_SERVER_ERROR); throw new HttpException(err.message, HttpStatus.INTERNAL_SERVER_ERROR);
} }
+2 -2
View File
@@ -30,8 +30,8 @@ export class RoomController {
@Post() @Post()
async addRoom(@Body() addRoomDto: AddRoomDto) { async addRoom(@Body() addRoomDto: AddRoomDto) {
try { try {
await this.roomService.addRoom(addRoomDto); const room = await this.roomService.addRoom(addRoomDto);
return { message: 'Room added successfully' }; return { message: 'Room added successfully', uuid: room.uuid };
} catch (error) { } catch (error) {
throw new HttpException( throw new HttpException(
error.message || 'Internal server error', error.message || 'Internal server error',
+2 -1
View File
@@ -32,11 +32,12 @@ export class RoomService {
}, },
}); });
await this.spaceRepository.save({ const room = await this.spaceRepository.save({
spaceName: addRoomDto.roomName, spaceName: addRoomDto.roomName,
parent: { uuid: addRoomDto.unitUuid }, parent: { uuid: addRoomDto.unitUuid },
spaceType: { uuid: spaceType.uuid }, spaceType: { uuid: spaceType.uuid },
}); });
return room;
} catch (err) { } catch (err) {
throw new HttpException(err.message, HttpStatus.INTERNAL_SERVER_ERROR); throw new HttpException(err.message, HttpStatus.INTERNAL_SERVER_ERROR);
} }
+2 -2
View File
@@ -32,8 +32,8 @@ export class UnitController {
@Post() @Post()
async addUnit(@Body() addUnitDto: AddUnitDto) { async addUnit(@Body() addUnitDto: AddUnitDto) {
try { try {
await this.unitService.addUnit(addUnitDto); const unit = await this.unitService.addUnit(addUnitDto);
return { message: 'Unit added successfully' }; return { message: 'Unit added successfully', uuid: unit.uuid };
} catch (error) { } catch (error) {
throw new HttpException( throw new HttpException(
error.message || 'Internal server error', error.message || 'Internal server error',
+2 -1
View File
@@ -35,11 +35,12 @@ export class UnitService {
}, },
}); });
await this.spaceRepository.save({ const unit = await this.spaceRepository.save({
spaceName: addUnitDto.unitName, spaceName: addUnitDto.unitName,
parent: { uuid: addUnitDto.floorUuid }, parent: { uuid: addUnitDto.floorUuid },
spaceType: { uuid: spaceType.uuid }, spaceType: { uuid: spaceType.uuid },
}); });
return unit;
} catch (err) { } catch (err) {
throw new HttpException(err.message, HttpStatus.INTERNAL_SERVER_ERROR); throw new HttpException(err.message, HttpStatus.INTERNAL_SERVER_ERROR);
} }