ammar/backend
1
0
Fork 0
mirror of https://github.com/SyncrowIOT/backend.git synced 2025-07-16 18:56:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #186 from SyncrowIOT/bugfix/fix-error-on-community-update-error

Browse Source 
updated error message for update community with existing name
This commit is contained in:
hannathkadher
2024-12-31 10:15:26 +04:00
committed by GitHub
parent 5220722579 e56bd88104
commit 53b0404ed5
1 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/community/services/community.service.ts
View File

@ -31,15 +31,7 @@ export class CommunityService {
const project = await this.validateProject(param.projectUuid);
const existingCommunity = await this.communityRepository.findOneBy({
name,
});
if (existingCommunity) {
throw new HttpException(
`A community with the name '${name}' already exists.`,
HttpStatus.BAD_REQUEST,
);
}
await this.validateName(name);
// Create the new community entity
const community = this.communityRepository.create({
@ -148,6 +140,7 @@ export class CommunityService {
try {
const { name } = updateCommunityDto;
if (name != community.name) await this.validateName(name);
community.name = name;
@ -163,7 +156,10 @@ export class CommunityService {
throw err; // If it's an HttpException, rethrow it
} else {
// Throw a generic 404 error if anything else goes wrong
throw new HttpException('Community not found', HttpStatus.NOT_FOUND);
throw new HttpException(
`An Internal exception has been occured ${err}`,
HttpStatus.INTERNAL_SERVER_ERROR,
);
}
}
}
@ -234,4 +230,16 @@ export class CommunityService {
}
return project;
}
private async validateName(name: string) {
const existingCommunity = await this.communityRepository.findOneBy({
name,
});
if (existingCommunity) {
throw new HttpException(
`A community with the name '${name}' already exists.`,
HttpStatus.BAD_REQUEST,
);
}
}
}