ammar/backend
1
0
Fork 0
mirror of https://github.com/SyncrowIOT/backend.git synced 2025-07-15 18:27:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor code to remove duplicate code and improve readability

Browse Source
This commit is contained in:
faris Aljohari
2024-06-02 15:21:07 +03:00
parent cc5e61a5f2
commit 42b849b3c5
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/device/services/device.service.ts
View File

@ -103,7 +103,6 @@ export class DeviceService {
const devicesData = await Promise.all( const devicesData = await Promise.all(
devices.map(async (device) => { devices.map(async (device) => {
return { return {
uuid: device.uuid,
haveRoom: device.spaceDevice ? true : false, haveRoom: device.spaceDevice ? true : false,
productUuid: device.productDevice.uuid, productUuid: device.productDevice.uuid,
productType: device.productDevice.prodType, productType: device.productDevice.prodType,
@ -111,6 +110,7 @@ export class DeviceService {
...(await this.getDeviceDetailsByDeviceIdTuya( ...(await this.getDeviceDetailsByDeviceIdTuya(
device.deviceTuyaUuid, device.deviceTuyaUuid,
)), )),
uuid: device.uuid,
} as GetDeviceDetailsInterface; } as GetDeviceDetailsInterface;
}), }),
); );
@ -149,7 +149,6 @@ export class DeviceService {
const devicesData = await Promise.all( const devicesData = await Promise.all(
devices.map(async (device) => { devices.map(async (device) => {
return { return {
uuid: device.uuid,
haveRoom: device.spaceDevice ? true : false, haveRoom: device.spaceDevice ? true : false,
productUuid: device.productDevice.uuid, productUuid: device.productDevice.uuid,
productType: device.productDevice.prodType, productType: device.productDevice.prodType,
@ -157,6 +156,7 @@ export class DeviceService {
...(await this.getDeviceDetailsByDeviceIdTuya( ...(await this.getDeviceDetailsByDeviceIdTuya(
device.deviceTuyaUuid, device.deviceTuyaUuid,
)), )),
uuid: device.uuid,
} as GetDeviceDetailsInterface; } as GetDeviceDetailsInterface;
}), }),
); );

2
src/unit/services/unit.service.ts
View File

@ -303,8 +303,6 @@ export class UnitService {
type: updatedUnit.spaceType.type, type: updatedUnit.spaceType.type,
}; };
} catch (err) { } catch (err) {
console.log('err', err);
if (err instanceof BadRequestException) { if (err instanceof BadRequestException) {
throw err; throw err;
} else { } else {