ammar/backend
1
0
Fork 0
mirror of https://github.com/SyncrowIOT/backend.git synced 2025-07-15 18:27:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #44 from SyncrowIOT/fix-some-issues

Browse Source 
Refactor code to remove duplicate code and improve readability
This commit is contained in:
faris Aljohari
2024-06-02 15:22:16 +03:00
committed by GitHub
parent 62a8871243 42b849b3c5
commit 36ea87ec86
2 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/device/services/device.service.ts
View File

@ -103,7 +103,6 @@ export class DeviceService {
const devicesData = await Promise.all(
devices.map(async (device) => {
return {
uuid: device.uuid,
haveRoom: device.spaceDevice ? true : false,
productUuid: device.productDevice.uuid,
productType: device.productDevice.prodType,
@ -111,6 +110,7 @@ export class DeviceService {
...(await this.getDeviceDetailsByDeviceIdTuya(
device.deviceTuyaUuid,
)),
uuid: device.uuid,
} as GetDeviceDetailsInterface;
}),
);
@ -149,7 +149,6 @@ export class DeviceService {
const devicesData = await Promise.all(
devices.map(async (device) => {
return {
uuid: device.uuid,
haveRoom: device.spaceDevice ? true : false,
productUuid: device.productDevice.uuid,
productType: device.productDevice.prodType,
@ -157,6 +156,7 @@ export class DeviceService {
...(await this.getDeviceDetailsByDeviceIdTuya(
device.deviceTuyaUuid,
)),
uuid: device.uuid,
} as GetDeviceDetailsInterface;
}),
);

2
src/unit/services/unit.service.ts
View File

@ -303,8 +303,6 @@ export class UnitService {
type: updatedUnit.spaceType.type,
};
} catch (err) {
console.log('err', err);
if (err instanceof BadRequestException) {
throw err;
} else {