Jira-13 sonar fixes

zod_bank/junior/views.py

@@ -1,36 +1,36 @@
-from django.shortcuts import render
-from rest_framework import (pagination, viewsets, status, generics, mixins)
-from rest_framework.decorators import action
-from rest_framework.response import Response
-from django.views.decorators.csrf import csrf_exempt
-# Create your views here.
+"""Junior view file"""
 from rest_framework import viewsets, status
-from rest_framework.response import Response
-from .serializers import CreateJuniorSerializer
-from django.contrib.auth.models import User
 from rest_framework.permissions import IsAuthenticated
-from base.constants import GUARDIAN, JUNIOR, SUPERUSER
+"""Django app import"""
 from junior.models import Junior
+from .serializers import CreateJuniorSerializer
 from guardian.models import Guardian
 from base.messages import ERROR_CODE, SUCCESS_CODE
 from account.utils import custom_response, custom_error_response
-
+# Create your views here.
 class UpdateJuniorProfile(viewsets.ViewSet):
+    """Update junior profile"""
     serializer_class = CreateJuniorSerializer
     permission_classes = [IsAuthenticated]
 
     def create(self, request, *args, **kwargs):
-        serializer = CreateJuniorSerializer(context={"user":request.user,"first_name":request.data.get('first_name', ''),
-                                                       "last_name": request.data.get('last_name',' ')}, data=request.data)
+        """Use CreateJuniorSerializer"""
+        serializer = CreateJuniorSerializer(context={"user":request.user,
+                                                     "first_name":request.data.get('first_name', ''),
+                                                     "last_name": request.data.get('last_name',' ')},
+                                            data=request.data)
         if serializer.is_valid():
+            """save serializer"""
             serializer.save()
             return custom_response(None, serializer.data, response_status=status.HTTP_200_OK)
         return custom_error_response(serializer.errors, response_status=status.HTTP_400_BAD_REQUEST)
 
 class ValidateGuardianCode(viewsets.ViewSet):
+    """Check guardian code exist or not"""
     permission_classes = [IsAuthenticated]
 
     def list(self, request, *args, **kwargs):
+        """check guardian code"""
         guardian_code = request.data.get('guardian_code')
         for code in guardian_code:
             guardian_data = Guardian.objects.filter(guardian_code=code).exists()