ammar/zod-backend
1
0
Fork 0
mirror of https://github.com/HamzaSha1/zod-backend.git synced 2025-11-26 00:24:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #44 from HamzaSha1/ZOD-341-junior-a-child-can-edit-their-email-to-an-existing-email-causing-multiple-child-accounts-to-share-the-same-login

Browse Source 
Zod 341 junior a child can edit their email to an existing email causing multiple child accounts to share the same login
This commit is contained in:
abdalhamid99
2025-10-20 14:27:40 +03:00
committed by GitHub
parent 7bfc14f0d9 4f778f7904
commit 39a0b131b8
2 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/user/dtos/request/update-user.request.dto.ts
View File

@ -1,5 +1,5 @@
import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger'; import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
import { IsDateString, IsEnum, IsNotEmpty, IsOptional, IsString, IsUUID } from 'class-validator'; import { IsDateString, IsEmail, IsEnum, IsNotEmpty, IsOptional, IsString, IsUUID } from 'class-validator';
import { i18nValidationMessage as i18n } from 'nestjs-i18n'; import { i18nValidationMessage as i18n } from 'nestjs-i18n';
import { Gender } from '~/customer/enums'; import { Gender } from '~/customer/enums';
export class UpdateUserRequestDto { export class UpdateUserRequestDto {
@ -15,6 +15,11 @@ export class UpdateUserRequestDto {
@IsOptional() @IsOptional()
lastName!: string; lastName!: string;
@ApiPropertyOptional({ example: 'child@example.com' })
@IsEmail({}, { message: i18n('validation.IsEmail', { path: 'general', property: 'user.email' }) })
@IsOptional()
email!: string;
@ApiProperty({ example: '123e4567-e89b-12d3-a456-426614174000' }) @ApiProperty({ example: '123e4567-e89b-12d3-a456-426614174000' })
@IsUUID('4', { message: i18n('validation.IsUUID', { path: 'general', property: 'user.profilePictureId' }) }) @IsUUID('4', { message: i18n('validation.IsUUID', { path: 'general', property: 'user.profilePictureId' }) })
@IsOptional() @IsOptional()

8
src/user/services/user.service.ts
View File

@ -191,6 +191,14 @@ export class UserService {
async updateUser(userId: string, data: UpdateUserRequestDto) { async updateUser(userId: string, data: UpdateUserRequestDto) {
await this.validateProfilePictureId(data.profilePictureId, userId); await this.validateProfilePictureId(data.profilePictureId, userId);
if (data.email) {
const userWithEmail = await this.findUser({ email: data.email });
if (userWithEmail && userWithEmail.id !== userId) {
this.logger.error(`Email ${data.email} is already taken by another user`);
throw new BadRequestException('USER.EMAIL_ALREADY_TAKEN');
}
}
this.logger.log(`Updating user ${userId} with data ${JSON.stringify(data)}`); this.logger.log(`Updating user ${userId} with data ${JSON.stringify(data)}`);
const { gender, dateOfBirth, ...userData } = data; const { gender, dateOfBirth, ...userData } = data;