ammar/backend
1
0
Fork 0
mirror of https://github.com/SyncrowIOT/backend.git synced 2025-11-26 12:44:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

added enums to replace constants

Browse Source
This commit is contained in:
unknown
2024-10-06 15:44:49 +03:00
parent a5c1cad01c
commit 9a868c5757
68 changed files with 547 additions and 202 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/device/services/device.service.ts
View File

@ -35,6 +35,8 @@ import { In } from 'typeorm';
import { ProductType } from '@app/common/constants/product-type.enum';
import { SpaceRepository } from '@app/common/modules/space/repositories';
import { DeviceStatusFirebaseService } from '@app/common/firebase/devices-status/services/devices-status.service';
import { DeviceStatuses } from '@app/common/constants/device-status.enum';
import { CommonErrorCodes } from '@app/common/constants/error-codes.enum';
@Injectable()
export class DeviceService {
@ -106,7 +108,7 @@ export class DeviceService {
}
return deviceSaved;
} catch (error) {
if (error.code === '23505') {
if (error.code === CommonErrorCodes.DUPLICATE_ENTITY) {
throw new HttpException(
'Device already exists',
HttpStatus.BAD_REQUEST,
@ -355,7 +357,7 @@ export class DeviceService {
const failedResults = [];
for (const result of results) {
if (result.status === 'fulfilled') {
if (result.status === DeviceStatuses.FULLFILLED) {
const { deviceUuid, result: operationResult } = result.value;
if (operationResult.success) {
@ -457,7 +459,7 @@ export class DeviceService {
const failedResults = [];
for (const result of results) {
if (result.status === 'fulfilled') {
if (result.status === DeviceStatuses.FULLFILLED) {
const { deviceUuid, result: operationResult } = result.value;
if (operationResult.success) {
@ -819,7 +821,8 @@ export class DeviceService {
await this.getDevicesInstructionStatus(device.uuid);
const batteryStatus: any = doorLockInstructionsStatus.status.find(
(status: any) => status.code === 'residual_electricity',
(status: any) =>
status.code === batteryStatus.RESIDUAL_ELECTRICITY,
);
if (batteryStatus) {
@ -832,7 +835,7 @@ export class DeviceService {
await this.getDevicesInstructionStatus(device.uuid);
const batteryStatus: any = doorSensorInstructionsStatus.status.find(
(status: any) => status.code === 'battery_percentage',
(status: any) => status.code === batteryStatus.BATTERY_PERCENTAGE,
);
if (batteryStatus) {
@ -845,7 +848,7 @@ export class DeviceService {
await this.getDevicesInstructionStatus(device.uuid);
const batteryStatus: any = doorSensorInstructionsStatus.status.find(
(status: any) => status.code === 'battery_percentage',
(status: any) => status.code === batteryStatus.BATTERY_PERCENTAGE,
);
if (batteryStatus) {
@ -877,7 +880,7 @@ export class DeviceService {
// Filter out rejected promises and extract the fulfilled values
const fulfilledDevices = devicesData
.filter((result) => result.status === 'fulfilled')
.filter((result) => result.status === DeviceStatuses.FULLFILLED)
.map(
(result) =>
(result as PromiseFulfilledResult<GetDeviceDetailsInterface>).value,