ammar/backend
1
0
Fork 0
mirror of https://github.com/SyncrowIOT/backend.git synced 2025-11-26 10:24:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve device retrieval logic in addDeviceStatusToFirebase method

Browse Source
This commit is contained in:
faris Aljohari
2025-06-25 08:13:02 -06:00
parent 3fcfe2d92f
commit 68d2d3b53d
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
libs/common/src/firebase/devices-status/services/devices-status.service.ts
View File

@ -131,10 +131,19 @@ export class DeviceStatusFirebaseService {
async addDeviceStatusToFirebase( async addDeviceStatusToFirebase(
addDeviceStatusDto: AddDeviceStatusDto, addDeviceStatusDto: AddDeviceStatusDto,
deviceCache: Map<string, any>, deviceCache?: Map<string, any>,
): Promise<AddDeviceStatusDto | null> { ): Promise<AddDeviceStatusDto | null> {
try { try {
const device = deviceCache.get(addDeviceStatusDto.deviceTuyaUuid); let device;
if (deviceCache) {
device = deviceCache.get(addDeviceStatusDto.deviceTuyaUuid);
} else {
device = await this.getDeviceByDeviceTuyaUuid(
addDeviceStatusDto.deviceTuyaUuid,
);
}
if (!device?.uuid) { if (!device?.uuid) {
console.log( console.log(
`⛔ Skipping Firebase update for unknown device: ${addDeviceStatusDto.deviceTuyaUuid}`, `⛔ Skipping Firebase update for unknown device: ${addDeviceStatusDto.deviceTuyaUuid}`,
@ -142,7 +151,6 @@ export class DeviceStatusFirebaseService {
return null; return null;
} }
// Ensure product info and uuid are attached
addDeviceStatusDto.deviceUuid = device.uuid; addDeviceStatusDto.deviceUuid = device.uuid;
addDeviceStatusDto.productUuid = device.productDevice?.uuid; addDeviceStatusDto.productUuid = device.productDevice?.uuid;
addDeviceStatusDto.productType = device.productDevice?.prodType; addDeviceStatusDto.productType = device.productDevice?.prodType;