ammar/backend
1
0
Fork 0
mirror of https://github.com/SyncrowIOT/backend.git synced 2025-11-26 13:54:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #16 from SyncrowIOT/fix-get-device-group-api

Browse Source 
Refactor device service to fetch devices by group ID
This commit is contained in:
Ammar Qaffaf
2024-03-26 12:35:00 +03:00
committed by GitHub
parent 4d6c4ed787 ed210e94c7
commit 0634f342e8
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/device/services/device.service.ts
View File

@ -74,15 +74,18 @@ export class DeviceService {
} }
async getDevicesByGroupId(getDeviceByGroupIdDto: GetDeviceByGroupIdDto) { async getDevicesByGroupId(getDeviceByGroupIdDto: GetDeviceByGroupIdDto) {
try { try {
const response = await this.getDevicesByGroupIdTuya( const devicesIds: GetDevicesByGroupIdInterface =
getDeviceByGroupIdDto, await this.getDevicesByGroupIdTuya(getDeviceByGroupIdDto);
const devicesDetails = await Promise.all(
devicesIds.result.data_list.map(async (device: any) => {
const deviceData = await this.getDevicesByDeviceId(device.dev_id);
return deviceData.result;
}),
); );
return { return {
success: response.success, success: devicesIds.success,
devices: response.result.data_list, devices: devicesDetails,
count: response.result.count, msg: devicesIds.msg,
msg: response.msg,
}; };
} catch (error) { } catch (error) {
throw new HttpException( throw new HttpException(
@ -96,12 +99,11 @@ export class DeviceService {
getDeviceByGroupIdDto: GetDeviceByGroupIdDto, getDeviceByGroupIdDto: GetDeviceByGroupIdDto,
): Promise<GetDevicesByGroupIdInterface> { ): Promise<GetDevicesByGroupIdInterface> {
try { try {
const path = `/v2.0/cloud/thing/group`; const path = `/v2.0/cloud/thing/group/${getDeviceByGroupIdDto.groupId}/devices`;
const response = await this.tuya.request({ const response = await this.tuya.request({
method: 'GET', method: 'GET',
path, path,
query: { query: {
space_id: getDeviceByGroupIdDto.groupId,
page_size: getDeviceByGroupIdDto.pageSize, page_size: getDeviceByGroupIdDto.pageSize,
page_no: getDeviceByGroupIdDto.pageNo, page_no: getDeviceByGroupIdDto.pageNo,
}, },